From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: common/xbps-src/shutils/show.sh: make show display consistent
Date: Mon, 19 Dec 2022 01:27:03 +0100 [thread overview]
Message-ID: <20221219002703.qUn4bw1hvbXwyNjHPiCjRQJFrMwHJAtWsUM9aAVgz3k@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41032@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
There's a merged pull request on the void-packages repository
common/xbps-src/shutils/show.sh: make show display consistent
https://github.com/void-linux/void-packages/pull/41032
Description:
previously, if there was a newline in some variables, it would not format
properly in `xbps-src show`. This fixes it by always splitting it by word
in some cases, like if there is a new line in the variable's value, and
removing internal commas in some cases.
This logic was split into a function for consistency.
fixes #40996
Example:
```
$ ./xbps-src show keepassxc
pkgname: keepassxc
...
License(s): GPL-3.0-or-later
License(s): BSD-3-Clause
License(s): CC0-1.0
License(s): LGPL-2.0-only
License(s): LGPL-2.1-only
License(s): LGPL-3.0-or-later
License(s): Nokia-Qt-exception-1.1
License(s): MIT
License(s): BSL-1.0
```
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
prev parent reply other threads:[~2022-12-19 0:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 6:25 [PR PATCH] common/xbps-src/shutils/show.sh: display `$license` one-per-line classabbyamp
2022-12-15 20:50 ` meator
2022-12-15 21:52 ` meator
2022-12-15 21:55 ` classabbyamp
2022-12-16 3:29 ` [PR PATCH] [Updated] " classabbyamp
2022-12-16 3:44 ` [PR REVIEW] common/xbps-src/shutils/show.sh: make show display consistent CameronNemo
2022-12-16 3:45 ` classabbyamp
2022-12-16 3:46 ` [PR PATCH] [Updated] " classabbyamp
2022-12-16 3:49 ` [PR REVIEW] " CameronNemo
2022-12-16 3:51 ` [PR PATCH] [Updated] " classabbyamp
2022-12-16 4:26 ` CameronNemo
2022-12-19 0:27 ` classabbyamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221219002703.qUn4bw1hvbXwyNjHPiCjRQJFrMwHJAtWsUM9aAVgz3k@z \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).