Re: [PR PATCH] [Updated] New package: imhex-1.25.0

[classabbyamp <classabbyamp@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages new/imhex
https://github.com/void-linux/void-packages/pull/36967

New package: imhex-1.25.0
closes #36954

This template will be able to be cleaned up a bit once capstone v5 is released (currently at rc2).

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**


A patch file from https://github.com/void-linux/void-packages/pull/36967.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new/imhex-36967.patch --]
[-- Type: text/x-diff, Size: 3430 bytes --]

From 2731cafbf0511c495559c6bca06e89b47606dd0b Mon Sep 17 00:00:00 2001
From: classabbyamp <dev@placeviolette.net>
Date: Tue, 3 May 2022 02:27:08 -0400
Subject: [PATCH] New package: imhex-1.25.0

closes #36954
---
 srcpkgs/imhex-patterns           |  1 +
 srcpkgs/imhex/patches/musl.patch | 11 +++++++
 srcpkgs/imhex/template           | 53 ++++++++++++++++++++++++++++++++
 3 files changed, 65 insertions(+)
 create mode 120000 srcpkgs/imhex-patterns
 create mode 100644 srcpkgs/imhex/patches/musl.patch
 create mode 100644 srcpkgs/imhex/template

diff --git a/srcpkgs/imhex-patterns b/srcpkgs/imhex-patterns
new file mode 120000
index 000000000000..9f335cad9f82
--- /dev/null
+++ b/srcpkgs/imhex-patterns
@@ -0,0 +1 @@
+imhex
\ No newline at end of file
diff --git a/srcpkgs/imhex/patches/musl.patch b/srcpkgs/imhex/patches/musl.patch
new file mode 100644
index 000000000000..845cabbbe64a
--- /dev/null
+++ b/srcpkgs/imhex/patches/musl.patch
@@ -0,0 +1,11 @@
+--- a/ImHex/plugins/builtin/include/content/providers/file_provider.hpp
++++ b/ImHex/plugins/builtin/include/content/providers/file_provider.hpp
+@@ -12,7 +12,7 @@
+ #else
+     #include <sys/mman.h>
+     #include <unistd.h>
+-    #include <sys/fcntl.h>
++    #include <fcntl.h>
+ #endif
+ 
+ namespace hex::plugin::builtin {
diff --git a/srcpkgs/imhex/template b/srcpkgs/imhex/template
new file mode 100644
index 000000000000..29155de36532
--- /dev/null
+++ b/srcpkgs/imhex/template
@@ -0,0 +1,53 @@
+# Template file for 'imhex'
+pkgname=imhex
+version=1.25.0
+revision=1
+create_wrksrc=yes
+build_wrksrc="ImHex"
+build_style=cmake
+build_helper=qemu
+# XXX: when capstone v5 is out, -DUSE_SYSTEM_CAPSTONE=ON
+configure_args="-DIMHEX_OFFLINE_BUILD=ON -DIMHEX_STRIP_RELEASE=OFF
+ -DUSE_SYSTEM_CURL=ON -DUSE_SYSTEM_FMT=ON -DUSE_SYSTEM_LLVM=ON
+ -DUSE_SYSTEM_YARA=ON -DUSE_SYSTEM_NLOHMANN_JSON=ON"
+hostmakedepends="pkg-config clang-tools-extra qemu-user-static"
+makedepends="libcurl-devel fmt-devel llvm12 jansson-devel yara-devel json-c++
+ freetype-devel glfw-devel gtk+3-devel python3-devel file-devel mbedtls-devel
+ clang-tools-extra"
+short_desc="Hex editor for reverse engineers and programmers"
+maintainer="classabbyamp <dev@placeviolette.net>"
+license="GPL-2.0-or-later"
+homepage="https://imhex.werwolv.net/"
+changelog="https://github.com/WerWolv/ImHex/releases"
+distfiles="https://github.com/WerWolv/ImHex/releases/download/v${version}/Full.Sources.tar.gz>imhex-${version}.tar.gz
+ https://github.com/WerWolv/ImHex-Patterns/archive/refs/tags/ImHex-v${version}.tar.gz>imhex-patterns-${version}.tar.gz"
+checksum="59817990bb1ab2377143480d4a26171ea631bcecdbc6682b2f79bed2a30e7eed
+ aff9b14a67bea48a06365b1d702af3b6c9cee9161912dd4daadd3f34ae8ee204"
+
+if [ "$XBPS_TARGET_WORDSIZE" = 32 ]; then
+	broken="uses i128"
+fi
+
+nocross="/bin/sh: line 1: /builddir/imhex-1.25.0/ImHex/build/lib/libimhex/external/libromfs/generator/generator-imhex: cannot execute binary file: Exec format error"
+
+do_check() {
+	cd build
+	ninja ${makejobs} unit_tests
+	# StoreAPI, TipsAPI, ContentAPI tests are flaky
+	ctest ${makejobs} -E '^.*API$'
+}
+
+post_install() {
+	vmkdir usr/share/imhex
+	for d in constants encodings includes magic patterns yara; do
+		vcopy ../ImHex-Patterns-ImHex-v${version}/$d usr/share/imhex
+	done
+}
+
+imhex-patterns_package() {
+	short_desc+=" - patterns and magic files"
+	depends="imhex"
+	pkg_install() {
+		vmove usr/share/imhex
+	}
+}