Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] OpenRCT2: update to 0.4.3.
Date: Mon, 19 Dec 2022 20:44:52 +0100	[thread overview]
Message-ID: <20221219194452.ClS7YhY87c-ZuydG46ed1ladaWcKnbUbNp4QSiTLVUs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41083@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41083#discussion_r1052577191

Comment:
let's also edit skip_extraction here instead of always skipping it, in the future it would be nice if pkglint aborted the build if something that doesn't exist is in skip_extraction

  parent reply	other threads:[~2022-12-19 19:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 13:26 [PR PATCH] " TinfoilSubmarine
2022-12-14 18:22 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-12-18 11:38 ` [PR REVIEW] " paper42
2022-12-19  2:31 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-12-19 19:44 ` paper42 [this message]
2022-12-20  1:33 ` TinfoilSubmarine
2022-12-24 23:30 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221219194452.ClS7YhY87c-ZuydG46ed1ladaWcKnbUbNp4QSiTLVUs@z \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).