From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] mpg123: move all "extra" plugings to mpg123-sdl, rename to mpg123-extras
Date: Wed, 28 Dec 2022 04:26:26 +0100 [thread overview]
Message-ID: <20221228032626.V6HkJi78T_fguv6PqWtNAOGjqAKSO__Mks3linv83tQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41323@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/41323#discussion_r1058034007
Comment:
Setting `<=` a high revision number is a bit hacky, but probably less horrible than the alternatives, which would be either hacking out a `next_version` variable so we could do `libmpg123>=${version}<${next_version}` (which would be fragile) or just dropping the `<=` (which might break some people's systems on upgrade). Done.
next prev parent reply other threads:[~2022-12-28 3:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 0:40 [PR PATCH] " ahesford
2022-12-28 1:44 ` [PR REVIEW] " sgn
2022-12-28 3:23 ` [PR PATCH] [Updated] " ahesford
2022-12-28 3:26 ` ahesford [this message]
2022-12-28 15:06 ` [PR PATCH] [Merged]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221228032626.V6HkJi78T_fguv6PqWtNAOGjqAKSO__Mks3linv83tQ@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).