From: jcgruenhage <jcgruenhage@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] gnupg: update to 2.4.0.
Date: Sun, 01 Jan 2023 18:13:24 +0100 [thread overview]
Message-ID: <20230101171324.UwfW8g7uvfmHgkSM-uPRIdjuQcv9SUMjBt4kmj4nzdQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41270@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
New review comment by jcgruenhage on void-packages repository
https://github.com/void-linux/void-packages/pull/41270#discussion_r1059776662
Comment:
Well, I have a checkout of the `gnupg` source locally, and I generate the patchset with `git format-patch v${version}` after doing `git rebase v${version}`, so all of those are rebased. Manually checking in which of those the context lines might have changed is additional churn that doesn't really add any value IMO, because having those updated patches in the repo doesn't really hurt anyway.. Is there a good reason to against this?
next prev parent reply other threads:[~2023-01-01 17:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-24 15:26 [PR PATCH] " jcgruenhage
2022-12-25 18:15 ` kruceter
2022-12-26 20:22 ` [PR PATCH] [Updated] " jcgruenhage
2022-12-26 20:26 ` jcgruenhage
2022-12-26 20:29 ` jcgruenhage
2022-12-27 1:33 ` [PR REVIEW] " sgn
2022-12-27 8:03 ` jcgruenhage
2022-12-27 9:37 ` [PR PATCH] [Updated] " jcgruenhage
2022-12-27 9:39 ` [PR REVIEW] " jcgruenhage
2022-12-27 9:40 ` [PR PATCH] [Updated] " jcgruenhage
2022-12-31 16:33 ` [PR REVIEW] " paper42
2023-01-01 17:13 ` jcgruenhage [this message]
2023-01-01 18:15 ` paper42
2023-01-01 18:23 ` jcgruenhage
2023-01-01 18:24 ` jcgruenhage
2023-01-02 3:50 ` sgn
2023-01-02 3:51 ` sgn
2023-01-14 13:02 ` [PR PATCH] [Updated] " jcgruenhage
2023-01-14 19:35 ` [PR REVIEW] " jcgruenhage
2023-01-15 9:18 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230101171324.UwfW8g7uvfmHgkSM-uPRIdjuQcv9SUMjBt4kmj4nzdQ@z \
--to=jcgruenhage@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).