From: meator <meator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] cmt: update to 1.18 and make it buildable
Date: Tue, 03 Jan 2023 14:19:23 +0100 [thread overview]
Message-ID: <20230103131923.ZXnxx-gbJcyq9MTT-POFukIxhnoGMdEPjsRF6S1OoRY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39583@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
New review comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/39583#discussion_r1060577846
Comment:
I don't think `sed` would be even necessary when `make_use_env` wouldn't be set. Xbps will override it whether the lines are there or not (when `make_use_env` is unset). But both of these approaches (just unsetting `make_use_env` or unsetting `make_use_env` and then doing `sed -e "/^CFLAGS/d; /^CXXFLAGS/d" -i "${build_wrksrc}/Makefile"`) have a flaw: they remove the `-fPIC` flag from `CFLAGS`. This flag affects compilation in a major way and shouldn't be removed without reason. `-fPIC` could be added to `make_build_args`. What do You think?
next prev parent reply other threads:[~2023-01-03 13:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 13:27 [PR PATCH] " meator
2022-12-31 1:55 ` github-actions
2023-01-02 7:15 ` [PR REVIEW] " kruceter
2023-01-02 7:15 ` kruceter
2023-01-02 7:15 ` kruceter
2023-01-03 13:08 ` [PR PATCH] [Updated] " meator
2023-01-03 13:09 ` meator
2023-01-03 13:19 ` meator [this message]
2023-01-03 13:20 ` [PR REVIEW] " meator
2023-01-03 13:21 ` meator
2023-01-07 21:49 ` kruceter
2023-01-07 22:18 ` kruceter
2023-01-10 15:00 ` meator
2023-01-10 15:23 ` kruceter
2023-04-11 1:51 ` github-actions
2023-04-25 1:53 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230103131923.ZXnxx-gbJcyq9MTT-POFukIxhnoGMdEPjsRF6S1OoRY@z \
--to=meator@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).