Github messages for voidlinux
 help / color / mirror / Atom feed
From: TinfoilSubmarine <TinfoilSubmarine@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: OpenLP: update to 3.0.0
Date: Tue, 10 Jan 2023 17:03:08 +0100	[thread overview]
Message-ID: <20230110160308.ff8WO5O3e9qyMfg2CFoAVyLqT0v_mQMr0v2troGuHSc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41526@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1536 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/41526#issuecomment-1377492604

Comment:
> I tried doing the tests by hand following the steps in their repo (https://gitlab.com/openlp/openlp/-/tree/master/tests) and failed the tests too, I asked in the openlp irc chat, it looks like there are some issues with Python 3.11 that only got recently discovered

If it's just a few and they're known to be Python 3.11 errors, not something on our end, we can skip/ignore/deselect them in the template I think. A few lines in `make_check_args` like this works.
```
diff --git a/srcpkgs/OpenLP/template b/srcpkgs/OpenLP/template
index 437fdb38aa..ace5308636 100644
--- a/srcpkgs/OpenLP/template
+++ b/srcpkgs/OpenLP/template
@@ -4,6 +4,11 @@ version=3.0.0
 revision=1
 create_wrksrc=yes
 build_style=python3-module
+make_check_args="--deselect tests/openlp_core/common/test_init.py::test_extension_loader_import_error
+ --deselect tests/openlp_core/common/test_init.py::test_extension_loader_os_error
+ --deselect tests/openlp_core/lib/test_serviceitem.py::test_to_dict_text_item
+ --deselect tests/openlp_core/lib/test_serviceitem.py::test_to_dict_image_item
+ --deselect tests/openlp_core/lib/test_serviceitem.py::test_to_dict_presentation_item"
 hostmakedepends="python3-setuptools qt5-host-tools"
 depends="python3-alembic python3-appdirs python3-BeautifulSoup4 python3-chardet
  python3-dbus python3-distro python3-Flask python3-Flask-Cors python3-lxml
```

  parent reply	other threads:[~2023-01-10 16:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-08 22:12 [PR PATCH] " joelchrono12
2023-01-08 23:39 ` [PR PATCH] [Updated] " joelchrono12
2023-01-09  1:33 ` joelchrono12
2023-01-09  1:42 ` joelchrono12
2023-01-09 13:36 ` TinfoilSubmarine
2023-01-09 14:27 ` joelchrono12
2023-01-09 14:36 ` TinfoilSubmarine
2023-01-09 14:37 ` TinfoilSubmarine
2023-01-09 17:33 ` joelchrono12
2023-01-09 17:33 ` joelchrono12
2023-01-10 15:49 ` TinfoilSubmarine
2023-01-10 16:03 ` TinfoilSubmarine [this message]
2023-01-10 16:22 ` joelchrono12
2023-01-10 16:23 ` joelchrono12
2023-01-10 16:23 ` joelchrono12
2023-01-10 16:37 ` TinfoilSubmarine
2023-01-10 16:51 ` [PR PATCH] [Updated] " joelchrono12
2023-01-10 16:52 ` joelchrono12
2023-01-20 16:28 ` TinfoilSubmarine
2023-02-23 20:11 ` [PR PATCH] [Updated] " Chocimier
2023-02-23 20:12 ` Chocimier
2023-02-26 15:59 ` joelchrono12
2023-03-22 21:40 ` [PR PATCH] [Merged]: " Chocimier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230110160308.ff8WO5O3e9qyMfg2CFoAVyLqT0v_mQMr0v2troGuHSc@z \
    --to=tinfoilsubmarine@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).