From: Piraty <Piraty@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: osmin-1.8.7
Date: Thu, 12 Jan 2023 13:44:28 +0100 [thread overview]
Message-ID: <20230112124428.DZ5EJhLztOtdX20wpWsESwY-HwoNVz2j64uZhd1rzxw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41561@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
New review comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/41561#discussion_r1068077756
Comment:
first, your list is incomplete as is (should use starred globs for `armv[67]`, as `armv7l-musl` isn't disallowed currently).
second, your point of restricting archs is to break early and not fail mid dependency installation step due to missing dependency `libomp-devel` , isn't it?
so it's technically incorrect to mix whitelist and blacklist this way, as using the blacklist like you do here makes it try build for archs that don't support libomp per llvm12's whitelist, for example `ppc`, `mips*`, `armv5*`.
so you either blacklist *all* unsupported archs (which are a lot and adds maintenance burden, so please don't) or duplicate the whitelist here to be explicit in sync with the limitation imposed by llvm12, therefore make it easy to maintain and technically correct
next prev parent reply other threads:[~2023-01-12 12:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 17:34 [PR PATCH] " Eloitor
2023-01-10 18:58 ` [PR REVIEW] " paper42
2023-01-10 18:58 ` paper42
2023-01-10 18:58 ` paper42
2023-01-10 18:58 ` paper42
2023-01-10 18:58 ` paper42
2023-01-10 21:49 ` [PR PATCH] [Updated] " Eloitor
2023-01-10 21:53 ` Eloitor
2023-01-10 22:09 ` [PR REVIEW] " Eloitor
2023-01-10 22:12 ` Eloitor
2023-01-10 22:12 ` Piraty
2023-01-10 22:20 ` [PR PATCH] [Updated] " Eloitor
2023-01-11 7:42 ` [PR REVIEW] " Eloitor
2023-01-12 12:43 ` Piraty
2023-01-12 12:43 ` Piraty
2023-01-12 12:44 ` Piraty [this message]
2023-01-12 15:24 ` [PR PATCH] [Updated] " Eloitor
2023-01-12 15:26 ` Eloitor
2023-01-12 15:28 ` [PR REVIEW] " Eloitor
2023-01-27 14:22 ` [PR PATCH] [Updated] " Eloitor
2023-02-05 20:18 ` Piraty
2023-02-10 11:43 ` Eloitor
2023-05-12 1:51 ` github-actions
2023-05-13 16:36 ` [PR PATCH] [Updated] " Eloitor
2023-05-15 0:35 ` New package: osmin-1.9.6 Piraty
2023-07-22 22:59 ` Piraty
2023-09-02 21:02 ` [PR PATCH] [Updated] " Eloitor
2023-09-02 21:03 ` [PR PATCH] [Updated] New package: osmin-1.9.7 Eloitor
2023-10-16 21:22 ` Eloitor
2023-10-16 21:25 ` New package: osmin-1.10.4 Eloitor
2023-10-25 17:01 ` [PR REVIEW] " Piraty
2023-10-25 17:01 ` Piraty
2023-10-25 21:38 ` Eloitor
2023-10-29 11:00 ` [PR PATCH] [Updated] " Eloitor
2023-10-30 13:34 ` Eloitor
2024-02-06 22:37 ` Eloitor
2024-02-07 8:38 ` [PR PATCH] [Updated] [WIP] New package: osmin-1.11.1 Eloitor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112124428.DZ5EJhLztOtdX20wpWsESwY-HwoNVz2j64uZhd1rzxw@z \
--to=piraty@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).