From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] devilutionX: update to 1.4.1 (maintainer version)
Date: Sun, 15 Jan 2023 14:06:04 +0100 [thread overview]
Message-ID: <20230115130604.5Fr6lML-QN3fD29vHDLBTJeG6EFE0pZoYJXUfRWno6k@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34039@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/34039#discussion_r1070590183
Comment:
> You did it, making a complex template, downloading a lot of software "manually", which makes maintenance more complicated, it is not easy to compile versions after 1.2.1, several distros would not yet have version 1.2.1 in their repositories, due to the problem with find SDL2 on various cpus architectures.
If CMake is fetching submodules at build time, that is unacceptable. Void templates should explicitly fetch all components of a build so that we can verify that the contents are as expected and the process is as reproducible as possible.
next prev parent reply other threads:[~2023-01-15 13:06 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 8:31 [PR PATCH] devilutionX: update to 1.3.0 bugcrazy
2021-11-12 8:32 ` bugcrazy
2021-11-12 8:44 ` [PR PATCH] [Updated] " bugcrazy
2021-11-14 20:11 ` [PR REVIEW] " abenson
2021-11-14 20:12 ` abenson
2021-11-14 20:14 ` abenson
2021-11-14 20:14 ` abenson
2021-11-14 20:32 ` [PR REVIEW] " abenson
2021-11-14 20:40 ` abenson
2021-11-17 3:30 ` [PR PATCH] [Updated] " bugcrazy
2021-11-17 3:31 ` [PR REVIEW] " bugcrazy
2021-11-17 3:32 ` bugcrazy
2021-11-17 3:33 ` bugcrazy
2021-11-17 3:44 ` [PR PATCH] [Updated] " bugcrazy
2021-11-17 3:45 ` [PR REVIEW] " bugcrazy
2021-11-17 3:46 ` bugcrazy
2021-11-17 5:25 ` bugcrazy
2021-11-17 18:16 ` abenson
2021-11-17 23:22 ` bugcrazy
2021-11-18 0:02 ` abenson
2021-11-18 0:02 ` abenson
2021-11-20 7:01 ` [PR PATCH] [Updated] " bugcrazy
2021-11-20 7:02 ` [PR REVIEW] " bugcrazy
2021-11-20 7:14 ` [PR PATCH] [Updated] " bugcrazy
2021-11-20 7:27 ` [PR REVIEW] " bugcrazy
2021-11-20 14:59 ` Chocimier
2021-11-20 22:10 ` [PR PATCH] [Updated] " bugcrazy
2021-11-20 22:12 ` bugcrazy
2021-11-24 22:02 ` [PR PATCH] [Updated] " bugcrazy
2022-01-03 17:35 ` bugcrazy
2022-04-17 0:32 ` bugcrazy
2022-07-16 2:13 ` devilutionX: update to 1.4.0 github-actions
2022-07-21 9:43 ` [PR PATCH] [Updated] " bugcrazy
2022-07-31 1:37 ` bugcrazy
2022-07-31 2:39 ` [PR PATCH] [Updated] " bugcrazy
2022-10-09 3:59 ` bugcrazy
2022-10-09 4:23 ` devilutionX: update to 1.4.1 (maintainer version) bugcrazy
2022-12-05 1:55 ` [PR PATCH] [Updated] " bugcrazy
2022-12-22 14:12 ` bugcrazy
2023-01-08 17:03 ` bugcrazy
2023-01-10 0:18 ` bugcrazy
2023-01-10 0:31 ` bugcrazy
2023-01-10 0:51 ` abenson
2023-01-10 0:51 ` abenson
2023-01-10 15:41 ` [PR PATCH] [Updated] " bugcrazy
2023-01-10 15:44 ` bugcrazy
2023-01-10 16:03 ` bugcrazy
2023-01-11 0:11 ` abenson
2023-01-11 0:11 ` [PR REVIEW] " abenson
2023-01-11 0:14 ` abenson
2023-01-11 0:15 ` abenson
2023-01-11 4:54 ` ahesford
2023-01-11 4:59 ` ahesford
2023-01-11 5:47 ` [PR PATCH] [Updated] " bugcrazy
2023-01-11 5:47 ` [PR REVIEW] " bugcrazy
2023-01-11 5:54 ` bugcrazy
2023-01-11 5:59 ` bugcrazy
2023-01-11 6:01 ` bugcrazy
2023-01-11 6:09 ` bugcrazy
2023-01-11 6:24 ` bugcrazy
2023-01-11 6:45 ` kruceter
2023-01-11 18:03 ` [PR REVIEW] " abenson
2023-01-11 18:04 ` abenson
2023-01-11 18:05 ` abenson
2023-01-13 2:21 ` [PR PATCH] [Updated] " bugcrazy
2023-01-13 2:33 ` bugcrazy
2023-01-13 2:40 ` [PR REVIEW] " bugcrazy
2023-01-13 2:52 ` [PR PATCH] [Updated] " bugcrazy
2023-01-13 3:06 ` [PR REVIEW] " bugcrazy
2023-01-13 3:16 ` bugcrazy
2023-01-13 3:34 ` bugcrazy
2023-01-13 14:10 ` [PR REVIEW] " abenson
2023-01-13 14:17 ` abenson
2023-01-13 14:22 ` abenson
2023-01-13 14:25 ` ahesford
2023-01-13 14:38 ` ahesford
2023-01-13 14:38 ` ahesford
2023-01-13 14:38 ` ahesford
2023-01-13 14:43 ` abenson
2023-01-14 23:59 ` [PR PATCH] [Updated] " bugcrazy
2023-01-15 0:02 ` [PR REVIEW] " bugcrazy
2023-01-15 0:02 ` bugcrazy
2023-01-15 0:04 ` bugcrazy
2023-01-15 0:05 ` bugcrazy
2023-01-15 0:06 ` bugcrazy
2023-01-15 0:07 ` bugcrazy
2023-01-15 0:11 ` kruceter
2023-01-15 0:12 ` kruceter
2023-01-15 0:26 ` classabbyamp
2023-01-15 0:26 ` classabbyamp
2023-01-15 0:26 ` classabbyamp
2023-01-15 0:26 ` classabbyamp
2023-01-15 1:09 ` [PR PATCH] [Updated] " bugcrazy
2023-01-15 1:12 ` [PR REVIEW] " bugcrazy
2023-01-15 1:13 ` bugcrazy
2023-01-15 1:13 ` bugcrazy
2023-01-15 1:14 ` bugcrazy
2023-01-15 1:29 ` kruceter
2023-01-15 1:29 ` kruceter
2023-01-15 1:29 ` kruceter
2023-01-15 3:41 ` [PR PATCH] [Updated] " bugcrazy
2023-01-15 3:47 ` [PR REVIEW] " bugcrazy
2023-01-15 4:03 ` bugcrazy
2023-01-15 4:05 ` bugcrazy
2023-01-15 4:14 ` bugcrazy
2023-01-15 5:22 ` kruceter
2023-01-15 5:22 ` kruceter
2023-01-15 5:23 ` kruceter
2023-01-15 5:30 ` kruceter
2023-01-15 13:06 ` ahesford [this message]
2023-01-15 15:58 ` bugcrazy
2023-01-15 16:38 ` bugcrazy
2023-01-15 16:40 ` bugcrazy
2023-01-15 16:43 ` ahesford
2023-01-15 17:07 ` bugcrazy
2023-01-15 17:12 ` ahesford
2023-01-15 19:32 ` classabbyamp
2023-01-15 19:32 ` [PR PATCH] [Closed]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230115130604.5Fr6lML-QN3fD29vHDLBTJeG6EFE0pZoYJXUfRWno6k@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).