Re: New package: logisim-evolution-3.8.0

[classabbyamp <classabbyamp@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 2160 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41603#issuecomment-1385836929

Comment:
to summarise:
```patch
From 528ba136392986688f1bfb7c4327fcf9125e1035 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Tue, 17 Jan 2023 13:15:15 -0500
Subject: [PATCH] pr review


diff --git a/srcpkgs/logisim-evolution/files/logisim-evolution b/srcpkgs/logisim-evolution/files/logisim-evolution
index 1039e777fb..7fdaedabdd 100644
--- a/srcpkgs/logisim-evolution/files/logisim-evolution
+++ b/srcpkgs/logisim-evolution/files/logisim-evolution
@@ -1,6 +1,4 @@
 #!/bin/sh
 
 export JAVA_HOME=/usr/lib/jvm/openjdk17
-$JAVA_HOME/bin/java -jar \
-       /usr/lib/@PKGNAME@/logisim-evolution-@VERSION@-all.jar $@
-
+$JAVA_HOME/bin/java -jar /usr/lib/logisim-evolution/logisim-evolution.jar $@
diff --git a/srcpkgs/logisim-evolution/template b/srcpkgs/logisim-evolution/template
index b59cd3c716..b89cacbb82 100644
--- a/srcpkgs/logisim-evolution/template
+++ b/srcpkgs/logisim-evolution/template
@@ -18,14 +18,11 @@ do_build() {
 }
 
 do_install() {
-       vinstall build/libs/logisim-evolution-${version}-all.jar 0644 usr/lib/${pkgname}
+       vinstall build/libs/logisim-evolution-${version}-all.jar 0644 usr/lib/logisim-evolution logisim-evolution.jar
 
        vbin ${FILESDIR}/logisim-evolution
-       sed -i -e "s/@VERSION@/${version}/g" -e "s/@PKGNAME@/${pkgname}/g" \
-               ${DESTDIR}/usr/bin/logisim-evolution
 
-       vinstall artwork/logisim-evolution-icon.svg 0644 \
-               usr/share/icons/hicolor/apps com.github.reds.LogisimEvolution.svg
-       vinstall support/Flatpak/com.github.reds.LogisimEvolution.desktop 0644 \
-               usr/share/applications
+       vinstall artwork/logisim-evolution-icon.svg 0644 usr/share/icons/hicolor/scalable/apps com.github.reds.LogisimEvolution.svg
+       vinstall support/Flatpak/com.github.reds.LogisimEvolution.desktop 0644 usr/share/applications
+       vinstall support/Flatpak/com.github.reds.LogisimEvolution.desktop 0644 usr/share/mime/packages
 }
-- 
2.39.0
```