From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] xdgmenumaker: update to 2.0
Date: Wed, 18 Jan 2023 21:56:00 +0100 [thread overview]
Message-ID: <20230118205600.a1ZDr54fnhkW9np9Qe-ef03AlCrqUlOquEUkmbtv5N8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41673@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/41673#discussion_r1080545806
Comment:
`$depends` is a list of runtime dependencies, not build dependencies. xdgmenumaker uses it [here](https://github.com/gapan/xdgmenumaker/blob/7dd8a63abd0de0151708339532c6a717b2741328/src/xdgmenumaker#L311) to figure out the icon path.
next prev parent reply other threads:[~2023-01-18 20:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 2:44 [PR PATCH] " bugcrazy
2023-01-16 2:51 ` bugcrazy
2023-01-16 5:30 ` paper42
2023-01-16 23:55 ` [PR PATCH] [Updated] " bugcrazy
2023-01-17 0:06 ` bugcrazy
2023-01-17 0:08 ` bugcrazy
2023-01-17 3:23 ` [PR REVIEW] " kruceter
2023-01-17 22:30 ` [PR PATCH] [Updated] " bugcrazy
2023-01-17 22:30 ` [PR REVIEW] " bugcrazy
2023-01-17 23:03 ` bugcrazy
2023-01-18 9:17 ` [PR REVIEW] " paper42
2023-01-18 19:17 ` bugcrazy
2023-01-18 20:56 ` paper42 [this message]
2023-01-18 23:48 ` [PR PATCH] [Updated] " bugcrazy
2023-01-18 23:49 ` [PR REVIEW] " bugcrazy
2023-01-18 23:58 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230118205600.a1ZDr54fnhkW9np9Qe-ef03AlCrqUlOquEUkmbtv5N8@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).