Re: [PR PATCH] [Closed]: Drop libssp from cross compilers

[sgn <sgn@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 3487 bytes --]

There's a closed pull request on the void-packages repository

Drop libssp from cross compilers
https://github.com/void-linux/void-packages/pull/41229

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

This fixes an issue introduced by: https://github.com/void-linux/void-packages/commit/b2d670be60b883192d12f79077fa79dff5395554 that was not noticed until now as the glibc cross compilers were never rebuilt until recently.

The above commit caused a symbol redefinition error between glibc and the fallback gcc libssp implementation when compiling qemu-user-static:
```
FAILED: subprojects/libvhost-user/link-test 
aarch64-linux-gnu-gcc  -o subprojects/libvhost-user/link-test subprojects/libvhost-user/link-test.p/link-test.c.o -I/usr/aarch64-linux-gnu/usr/include -L/usr/aarch64-linux-gnu/usr/lib -Wl,--as-needed -Wl,--no-undefined -pie -Wl,--whole-archive -Wl,--start-group subprojects/libvhost-user/libvhost-user.a -Wl,--end-group -Wl,--no-whole-archive -fstack-protector-strong -static-pie -Wl,-z,relro -Wl,-z,now -Wl,--warn-common -fstack-clash-protection -D_FORTIFY_SOURCE=2 -O2 -pipe -march=armv8-a -fdebug-prefix-map=/builddir/qemu-user-static-7.2.0=. -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -pthread
/usr/lib/gcc/aarch64-linux-gnu/12.2.0/../../../../aarch64-linux-gnu/bin/ld: /usr/aarch64-linux-gnu/usr/lib/libc.a(libc-start.o):(.data.rel.ro+0x0): multiple definition of `__stack_chk_guard'; /usr/aarch64-linux-gnu/usr/lib/libssp.a(ssp.o):/builddir/cross-aarch64-linux-gnu-0.35/gcc_build/aarch64-linux-gnu/libssp/../../../gcc-12.2.0/libssp/ssp.c:69: first defined here
collect2: error: ld returned 1 exit status
```

Note: this doesn't affect the ability to use ssp as glibc and musl have their own ssp implementations separate from libssp.
For reference Debian doesn't build libssp although it does manually create libssp_nonshared.a when compiling for musl, Alpine does the same thing: https://salsa.debian.org/toolchain-team/gcc/-/blob/gcc-12-debian/debian/rules2#L233 https://github.com/alpinelinux/aports/blob/6cdeaa93fe90cccc05e39fb4905dee70362892b8/main/musl/APKBUILD#L51-L53 Fedora afaict does build libssp but deletes libssp and libssp_nonshared after compiling: https://src.fedoraproject.org/rpms/gcc/blob/rawhide/f/gcc.spec#_1996

This also doesn't break packages linked against libssp as libssp.so is still provided by the libssp package in gcc (and there is libatomic which is provided by gcc but not the cross compilers so I don't think it is that crazy). There is a separate PR dropping the libssp package if we want to do that as well.

[ci skip]

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->