From: pascal-huber <pascal-huber@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: git-lfs: udpate to 3.3.0
Date: Mon, 23 Jan 2023 12:07:22 +0100 [thread overview]
Message-ID: <20230123110722.YNAaOsJXXZX_Shs1n8yVn3yPQfrKcraMtWEDHMnAtA8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41754@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 596 bytes --]
New comment by pascal-huber on void-packages repository
https://github.com/void-linux/void-packages/pull/41754#issuecomment-1400166673
Comment:
Maybe some clarification: @lemmi expressed some objections on IRC regarding overriding the default `do_build` because there could be issues for cross builds. However, I could not get it to compile with `go mod`/`go install` as in the go build style. The upstream way is to use the Makefile (which sets some variables and runs `go build`). From what I can see, the `go` build style takes care of the necessary variables (most importantly `GOARCH`).
next prev parent reply other threads:[~2023-01-23 11:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 11:31 [PR PATCH] " pascal-huber
2023-01-20 11:35 ` [PR PATCH] [Updated] " pascal-huber
2023-01-22 20:55 ` Piraty
2023-01-23 11:07 ` pascal-huber [this message]
2023-01-23 11:24 ` lemmi
2023-01-23 11:36 ` [PR PATCH] [Updated] " pascal-huber
2023-01-23 11:38 ` pascal-huber
2023-01-23 11:43 ` [PR REVIEW] " lemmi
2023-01-23 11:44 ` lemmi
2023-01-23 11:47 ` [PR PATCH] [Updated] " pascal-huber
2023-01-23 11:48 ` pascal-huber
2023-01-23 11:50 ` [PR REVIEW] " pascal-huber
2023-01-23 11:52 ` [PR PATCH] [Updated] " pascal-huber
2023-01-23 11:55 ` pascal-huber
2023-01-23 12:06 ` pascal-huber
2023-01-23 12:13 ` pascal-huber
2023-01-23 18:08 ` [PR PATCH] [Merged]: " lemmi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123110722.YNAaOsJXXZX_Shs1n8yVn3yPQfrKcraMtWEDHMnAtA8@z \
--to=pascal-huber@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).