Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] ubridge: update to 0.9.18.
@ 2023-01-25 15:22 tsndqst
  2023-01-25 15:27 ` tsndqst
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: tsndqst @ 2023-01-25 15:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 3756 bytes --]

There is a new pull request by tsndqst against master on the void-packages repository

https://github.com/tsndqst/void-packages ubridge
https://github.com/void-linux/void-packages/pull/41866

ubridge: update to 0.9.18.
<!-- Uncomment relevant sections and delete options which are not applicable -->
ubridge is not compiled with LINUX_RAW enabled so it cannot use `add_nio_linux_raw` to connect to network interfaces.
When ubridge is compiled with LINUX_RAW it works.

Below is the error I get in GNS3 when I use the current package of ubridge:
```
2023-01-25 09:17:20 ERROR route.py:221 Node error detected: UbridgeError
Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/gns3server/compute/base_node.py", line 660, in _ubridge_send
    await self._ubridge_hypervisor.send(command)
  File "/usr/lib/python3.11/site-packages/gns3server/utils/asyncio/__init__.py", line 164, in wrapper
    return await f(oself, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/gns3server/ubridge/ubridge_hypervisor.py", line 259, in send
    raise UbridgeError(data[-1][4:])
gns3server.ubridge.ubridge_error.UbridgeError: Unknown command 'add_nio_linux_raw'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/gns3server/web/route.py", line 200, in control_schema
    await func(request, response)
  File "/usr/lib/python3.11/site-packages/gns3server/handlers/api/compute/cloud_handler.py", line 147, in start
    await node.start()
  File "/usr/lib/python3.11/site-packages/gns3server/compute/builtin/nodes/cloud.py", line 232, in start
    raise e
  File "/usr/lib/python3.11/site-packages/gns3server/compute/builtin/nodes/cloud.py", line 229, in start
    await self._add_ubridge_connection(self._nios[port_number], port_number)
  File "/usr/lib/python3.11/site-packages/gns3server/compute/builtin/nodes/cloud.py", line 315, in _add_ubridge_connection
    await self._add_linux_ethernet(port_info, bridge_name)
  File "/usr/lib/python3.11/site-packages/gns3server/compute/builtin/nodes/cloud.py", line 357, in _add_linux_ethernet
    await self._ubridge_send('bridge add_nio_linux_raw {name} "{interface}"'.format(name=bridge_name, interface=interface))
  File "/usr/lib/python3.11/site-packages/gns3server/compute/base_node.py", line 662, in _ubridge_send
    raise UbridgeError("Error while sending command '{}': {}: {}".format(command, e, self._ubridge_hypervisor.read_stdout()))
gns3server.ubridge.ubridge_error.UbridgeError: Error while sending command 'bridge add_nio_linux_raw 15a9b700-ea53-446a-877a-b6cdd5decacd-2 "eth0"': Unknown command 'add_nio_linux_raw': uBridge version 0.9.18 running with libpcap version 1.10.3 (with TPACKET_V3)
```

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-GLIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64 (crossbuild)


A patch file from https://github.com/void-linux/void-packages/pull/41866.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ubridge-41866.patch --]
[-- Type: text/x-diff, Size: 924 bytes --]

From 2f91164eaeb692ddfdc74812e0901fa202bc8ba9 Mon Sep 17 00:00:00 2001
From: Tim Sandquist <tim.sandquist@gmail.com>
Date: Wed, 25 Jan 2023 08:34:51 -0600
Subject: [PATCH] ubridge: update to 0.9.18.

---
 srcpkgs/ubridge/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/ubridge/template b/srcpkgs/ubridge/template
index 55baf87b91cb..b0c9d1d1c277 100644
--- a/srcpkgs/ubridge/template
+++ b/srcpkgs/ubridge/template
@@ -1,7 +1,7 @@
 # Template file for 'ubridge'
 pkgname=ubridge
 version=0.9.18
-revision=1
+revision=2
 build_style=gnu-makefile
 make_build_args="SYSTEM_INIPARSER=1"
 makedepends="libpcap-devel iniparser-devel"
@@ -12,6 +12,8 @@ homepage="https://github.com/GNS3/ubridge"
 distfiles="${homepage}/archive/v${version}.tar.gz"
 checksum=7481e0f4a11c151c698baf5fbd5e474236aa408ff7f9b503e13feb091fbc38e7
 
+CFLAGS="$CFLAGS -DLINUX_RAW"
+
 do_install() {
 	vbin ubridge
 }

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: ubridge: update to 0.9.18.
  2023-01-25 15:22 [PR PATCH] ubridge: update to 0.9.18 tsndqst
@ 2023-01-25 15:27 ` tsndqst
  2023-01-25 15:43 ` [PR REVIEW] " CameronNemo
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: tsndqst @ 2023-01-25 15:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

New comment by tsndqst on void-packages repository

https://github.com/void-linux/void-packages/pull/41866#issuecomment-1403797631

Comment:
@CameronNemo Can you take a look at this?  I have been using this template for a while and just realized I hadn't pushed it up when testing GNS3 on aarch64 and ubridge failed to work until I recompiled it using this template.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] ubridge: update to 0.9.18.
  2023-01-25 15:22 [PR PATCH] ubridge: update to 0.9.18 tsndqst
  2023-01-25 15:27 ` tsndqst
@ 2023-01-25 15:43 ` CameronNemo
  2023-01-25 15:44 ` CameronNemo
  2023-01-25 16:15 ` [PR PATCH] [Updated] " tsndqst
  3 siblings, 0 replies; 5+ messages in thread
From: CameronNemo @ 2023-01-25 15:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New review comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/41866#discussion_r1086807516

Comment:
We have bash, so you could just

```suggestion
CFLAGS+=" -DLINUX_RAW"
```

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: ubridge: update to 0.9.18.
  2023-01-25 15:22 [PR PATCH] ubridge: update to 0.9.18 tsndqst
  2023-01-25 15:27 ` tsndqst
  2023-01-25 15:43 ` [PR REVIEW] " CameronNemo
@ 2023-01-25 15:44 ` CameronNemo
  2023-01-25 16:15 ` [PR PATCH] [Updated] " tsndqst
  3 siblings, 0 replies; 5+ messages in thread
From: CameronNemo @ 2023-01-25 15:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/41866#issuecomment-1403821707

Comment:
This change seems to make sense to me.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] ubridge: update to 0.9.18.
  2023-01-25 15:22 [PR PATCH] ubridge: update to 0.9.18 tsndqst
                   ` (2 preceding siblings ...)
  2023-01-25 15:44 ` CameronNemo
@ 2023-01-25 16:15 ` tsndqst
  3 siblings, 0 replies; 5+ messages in thread
From: tsndqst @ 2023-01-25 16:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 3761 bytes --]

There is an updated pull request by tsndqst against master on the void-packages repository

https://github.com/tsndqst/void-packages ubridge
https://github.com/void-linux/void-packages/pull/41866

ubridge: update to 0.9.18.
<!-- Uncomment relevant sections and delete options which are not applicable -->
ubridge is not compiled with LINUX_RAW enabled so it cannot use `add_nio_linux_raw` to connect to network interfaces.
When ubridge is compiled with LINUX_RAW it works.

Below is the error I get in GNS3 when I use the current package of ubridge:
```
2023-01-25 09:17:20 ERROR route.py:221 Node error detected: UbridgeError
Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/gns3server/compute/base_node.py", line 660, in _ubridge_send
    await self._ubridge_hypervisor.send(command)
  File "/usr/lib/python3.11/site-packages/gns3server/utils/asyncio/__init__.py", line 164, in wrapper
    return await f(oself, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/gns3server/ubridge/ubridge_hypervisor.py", line 259, in send
    raise UbridgeError(data[-1][4:])
gns3server.ubridge.ubridge_error.UbridgeError: Unknown command 'add_nio_linux_raw'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/gns3server/web/route.py", line 200, in control_schema
    await func(request, response)
  File "/usr/lib/python3.11/site-packages/gns3server/handlers/api/compute/cloud_handler.py", line 147, in start
    await node.start()
  File "/usr/lib/python3.11/site-packages/gns3server/compute/builtin/nodes/cloud.py", line 232, in start
    raise e
  File "/usr/lib/python3.11/site-packages/gns3server/compute/builtin/nodes/cloud.py", line 229, in start
    await self._add_ubridge_connection(self._nios[port_number], port_number)
  File "/usr/lib/python3.11/site-packages/gns3server/compute/builtin/nodes/cloud.py", line 315, in _add_ubridge_connection
    await self._add_linux_ethernet(port_info, bridge_name)
  File "/usr/lib/python3.11/site-packages/gns3server/compute/builtin/nodes/cloud.py", line 357, in _add_linux_ethernet
    await self._ubridge_send('bridge add_nio_linux_raw {name} "{interface}"'.format(name=bridge_name, interface=interface))
  File "/usr/lib/python3.11/site-packages/gns3server/compute/base_node.py", line 662, in _ubridge_send
    raise UbridgeError("Error while sending command '{}': {}: {}".format(command, e, self._ubridge_hypervisor.read_stdout()))
gns3server.ubridge.ubridge_error.UbridgeError: Error while sending command 'bridge add_nio_linux_raw 15a9b700-ea53-446a-877a-b6cdd5decacd-2 "eth0"': Unknown command 'add_nio_linux_raw': uBridge version 0.9.18 running with libpcap version 1.10.3 (with TPACKET_V3)
```

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-GLIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64 (crossbuild)


A patch file from https://github.com/void-linux/void-packages/pull/41866.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ubridge-41866.patch --]
[-- Type: text/x-diff, Size: 918 bytes --]

From 963a12cd4f44835ff72ff618529419a7cca0c5dc Mon Sep 17 00:00:00 2001
From: Tim Sandquist <tim.sandquist@gmail.com>
Date: Wed, 25 Jan 2023 08:34:51 -0600
Subject: [PATCH] ubridge: update to 0.9.18.

---
 srcpkgs/ubridge/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/ubridge/template b/srcpkgs/ubridge/template
index 55baf87b91cb..469c4c9bd683 100644
--- a/srcpkgs/ubridge/template
+++ b/srcpkgs/ubridge/template
@@ -1,7 +1,7 @@
 # Template file for 'ubridge'
 pkgname=ubridge
 version=0.9.18
-revision=1
+revision=2
 build_style=gnu-makefile
 make_build_args="SYSTEM_INIPARSER=1"
 makedepends="libpcap-devel iniparser-devel"
@@ -12,6 +12,8 @@ homepage="https://github.com/GNS3/ubridge"
 distfiles="${homepage}/archive/v${version}.tar.gz"
 checksum=7481e0f4a11c151c698baf5fbd5e474236aa408ff7f9b503e13feb091fbc38e7
 
+CFLAGS+=" -DLINUX_RAW"
+
 do_install() {
 	vbin ubridge
 }

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-01-25 16:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-25 15:22 [PR PATCH] ubridge: update to 0.9.18 tsndqst
2023-01-25 15:27 ` tsndqst
2023-01-25 15:43 ` [PR REVIEW] " CameronNemo
2023-01-25 15:44 ` CameronNemo
2023-01-25 16:15 ` [PR PATCH] [Updated] " tsndqst

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).