Re: [PR PATCH] [Updated] python3: skip more tests

[dkwo <dkwo@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages py3t
https://github.com/void-linux/void-packages/pull/41983

python3: skip more tests
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-musl)

@ahesford These tests fail for me on musl with `XBPS_CHECK_PKGS=yes`.
is it ok to exclude them, so that I can look for new failures related to openssl3?

A patch file from https://github.com/void-linux/void-packages/pull/41983.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-py3t-41983.patch --]
[-- Type: text/x-diff, Size: 2487 bytes --]

From 9942845b3e9d9659f89cef49023ba8b02b475b5f Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Mon, 30 Jan 2023 17:17:14 -0500
Subject: [PATCH] python3: skip more tests

---
 srcpkgs/python3/template | 37 +++++++++++++++++++++----------------
 1 file changed, 21 insertions(+), 16 deletions(-)

diff --git a/srcpkgs/python3/template b/srcpkgs/python3/template
index 972a3cf5a2ec..88852170a9cd 100644
--- a/srcpkgs/python3/template
+++ b/srcpkgs/python3/template
@@ -73,23 +73,28 @@ do_configure() {
 }
 
 do_check() {
+	local _fail
+
 	# Tests ignored due to expected failures:
-	# test_chown_*: relies on sane group membership not found in xbps-src
-	# test_getspnam_exception: expects shadow passwd db unreadable by user
-	# test_find_library_with_*: expects functionality patched out for musl
-	# test_openssl_version: LibreSSL version and OpenSSL_version_num disagree
-	# test_shared_ciphers: SSL advertises unexpected ciphers
-	# test_freeze_simple_script: requires in-tree expat, which we removed
-	#
-	# Test ignored due to failures for unknown reasons:
-	# test_session*: anomalies in SSL session handling
-	# test_localtime_daylight_*_dst_true: overflow in datetime.time.mktime
-	local opts="-i test_chown_* -i test_getspnam_exception \
-		-i test_find_library_with_* -i test_openssl_version \
-		-i test_shared_ciphers -i test_session* \
-		-i test_localtime_daylight_*_dst_true \
-		-i test_freeze_simple_script"
-	make ${makejobs} EXTRATESTOPTS="${opts}" quicktest
+	_fail="test_chown_*" # relies on sane group membership not found in xbps-src
+	_fail="$_fail test_getspnam_exception" # expects shadow passwd db unreadable by user
+	_fail="$_fail test_find_library_with_*" # expects functionality patched out for musl
+	_fail="$_fail test_openssl_version" # LibreSSL version and OpenSSL_version_num disagree
+	_fail="$_fail test_shared_ciphers" # SSL advertises unexpected ciphers
+	_fail="$_fail test_freeze_simple_script" # requires in-tree expat, which we removed
+
+	# musl failures:
+	_fail="$_fail test__locale test_c_locale_coercion test_locale test_os test_re"
+
+	# Tests ignored due to failures for unknown reasons:
+	_fail="$_fail test_ctypes test_tools"
+	_fail="$_fail test_session*" # anomalies in SSL session handling
+	_fail="$_fail test_localtime_daylight_*_dst_true" # overflow in datetime.time.mktime
+
+	# aarch64 failure:
+	_fail="$_fail test_spwd"
+
+	make quicktest TESTOPTS="${makejobs} --exclude ${_fail}"
 }
 
 do_install() {