From: kruceter <kruceter@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] PrusaSlicer: update to 2.5.0.
Date: Wed, 01 Feb 2023 19:45:04 +0100 [thread overview]
Message-ID: <20230201184504.YV5HStAoIZhdC7fYUzVlhywVeKb7hNnhZuZbeIMbq78@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41548@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 458 bytes --]
New review comment by kruceter on void-packages repository
https://github.com/void-linux/void-packages/pull/41548#discussion_r1093538768
Comment:
```suggestion
-DSLIC3R_ENC_CHECK=0 -DUSE_BLOSC=ON -DUSE_EXR=ON -DSLIC3R_PCH=OFF -DSLIC3R_ENABLE_FORMAT_STEP=OFF"
```
Why not just set it to `OFF`? Cmake triggers on booleans, not the contents of the variable:
```cmake
if (SLIC3R_ENABLE_FORMAT_STEP)
add_subdirectory(occt_wrapper)
endif ()
```
next prev parent reply other threads:[~2023-02-01 18:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 16:16 [PR PATCH] PrusaSlicer: update to 4.5.0 sinetek
2023-01-09 16:21 ` [PR PATCH] [Updated] " sinetek
2023-01-09 16:24 ` sinetek
2023-01-10 5:02 ` [PR REVIEW] " sgn
2023-01-10 5:02 ` sgn
2023-01-10 5:02 ` sgn
2023-01-10 19:21 ` sinetek
2023-01-10 19:21 ` sinetek
2023-01-10 19:22 ` sinetek
2023-01-10 19:30 ` sinetek
2023-01-10 19:32 ` [PR PATCH] [Updated] " sinetek
2023-01-10 19:35 ` sinetek
2023-01-10 22:31 ` [PR REVIEW] " kruceter
2023-01-14 21:55 ` [PR PATCH] [Updated] " sinetek
2023-01-14 21:59 ` [PR PATCH] [Updated] PrusaSlicer: update to 2.5.0 sinetek
2023-01-15 15:12 ` sinetek
2023-01-15 16:15 ` sinetek
2023-01-15 17:11 ` sinetek
2023-01-15 17:13 ` sinetek
2023-01-15 17:13 ` sinetek
2023-01-15 22:00 ` [PR PATCH] [Updated] " sinetek
2023-01-30 13:29 ` sinetek
2023-02-01 18:45 ` [PR REVIEW] " kruceter
2023-02-01 18:45 ` kruceter
2023-02-01 18:45 ` kruceter [this message]
2023-05-03 1:51 ` github-actions
2023-05-17 1:54 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201184504.YV5HStAoIZhdC7fYUzVlhywVeKb7hNnhZuZbeIMbq78@z \
--to=kruceter@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).