Github messages for voidlinux
 help / color / mirror / Atom feed
From: kruceter <kruceter@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] libgit2: update to 1.5.1
Date: Thu, 02 Feb 2023 01:42:02 +0100	[thread overview]
Message-ID: <20230202004202.NZpUitrMfxOgRKq1n9z_FJPGIJXSjzKbJjEVOzdeSc8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41873@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

New review comment by kruceter on void-packages repository

https://github.com/void-linux/void-packages/pull/41873#discussion_r1093880497

Comment:
```suggestion
Backported from:
https://github.com/libgit2/libgit2/commit/12d73c418253a5c396465079c2808e07de17a1db

diff --git a/tests/libgit2/CMakeLists.txt b/tests/libgit2/CMakeLists.txt
```

I see nothing wrong in removing the commit header, but it is better to indicate that you backported the patch from the "main" branch to clear confusion.

  reply	other threads:[~2023-02-02  0:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25 22:22 [PR PATCH] " tranzystorek-io
2023-02-02  0:42 ` kruceter [this message]
2023-02-02  0:42 ` [PR REVIEW] " kruceter
2023-02-02  0:44 ` kruceter
2023-02-02  0:58 ` [PR PATCH] [Updated] " tranzystorek-io
2023-02-02  0:58 ` [PR REVIEW] " tranzystorek-io
2023-02-02  0:59 ` tranzystorek-io
2023-02-02  1:19 ` kruceter
2023-02-02  1:31 ` [PR PATCH] [Merged]: " Vaelatern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230202004202.NZpUitrMfxOgRKq1n9z_FJPGIJXSjzKbJjEVOzdeSc8@z \
    --to=kruceter@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).