Github messages for voidlinux
 help / color / mirror / Atom feed
From: icp1994 <icp1994@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] gscreenshot: update to 3.3.0.
Date: Sun, 05 Feb 2023 18:46:53 +0100	[thread overview]
Message-ID: <20230205174653.MKAmcRZOuHfixWnwCOh_MeHfEQPZh1K7UI0uVcbdzl4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41905@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages gscreenshot
https://github.com/void-linux/void-packages/pull/41905

gscreenshot: update to 3.3.0.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

I think scrot shouldn't be a hard dependencny here since it has full [wayland compatibility](https://github.com/thenaterhood/gscreenshot#for-full-functionality-on-wayland-the-recommended-packages-are)

A patch file from https://github.com/void-linux/void-packages/pull/41905.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gscreenshot-41905.patch --]
[-- Type: text/x-diff, Size: 1822 bytes --]

From 60e539e6d0efaf37ca71bce1cd1a7ed061288a25 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 28 Jan 2023 01:19:46 +0530
Subject: [PATCH] gscreenshot: update to 3.3.0.

---
 srcpkgs/gscreenshot/template | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/srcpkgs/gscreenshot/template b/srcpkgs/gscreenshot/template
index 008172670ed4..a9af8ac0d8ee 100644
--- a/srcpkgs/gscreenshot/template
+++ b/srcpkgs/gscreenshot/template
@@ -1,15 +1,20 @@
 # Template file for 'gscreenshot'
 pkgname=gscreenshot
-version=2.17.1
-revision=2
+version=3.3.0
+revision=1
 build_style=python3-module
-hostmakedepends="python3-setuptools gettext"
-depends="gtk+3 python3-setuptools python3-Pillow python3-gobject scrot"
-short_desc="GUI front-end for the scrot program"
+hostmakedepends="python3-setuptools gettext go-md2man"
+# refer to https://github.com/thenaterhood/gscreenshot#installation
+# for optional dependencies across system configurations
+depends="gtk+3 python3-setuptools python3-Pillow python3-gobject"
+checkdepends="${depends} python3-mock python3-pytest"
+short_desc="GUI for multiple screenshot backends including scrot, PIL, and grim"
 maintainer="Rui Flora <rui.flora@gmail.com>"
-license="GPL-2.0-or-later"
+license="GPL-2.0-only"
 homepage="https://github.com/thenaterhood/gscreenshot"
-distfiles="https://github.com/thenaterhood/gscreenshot/archive/v${version}.tar.gz"
-checksum=f0cdf81e9ab483e11c04ed27141ac37dd6f24415968bc5f4c874e7b17ca5958d
-# doesn't ship any tests
-make_check=no
+distfiles="https://github.com/thenaterhood/gscreenshot/archive/refs/tags/v${version}.tar.gz"
+checksum=f05e695676cda97483c6cdbebaba9a708b5791e544e977016a772325a1d37231
+
+do_check() {
+	(cd src && PYTHONPATH="$(cd build/lib* && pwd)" python3 -m pytest ../test)
+}

  parent reply	other threads:[~2023-02-05 17:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 19:55 [PR PATCH] gscreenshot: update to 3.2.1 icp1994
2023-01-29  6:17 ` [PR PATCH] [Updated] " icp1994
2023-02-04 22:51 ` [PR REVIEW] gscreenshot: update to 3.3.0 paper42
2023-02-04 22:52 ` paper42
2023-02-05 17:36 ` [PR REVIEW] " icp1994
2023-02-05 17:46 ` icp1994 [this message]
2023-02-05 20:03 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230205174653.MKAmcRZOuHfixWnwCOh_MeHfEQPZh1K7UI0uVcbdzl4@z \
    --to=icp1994@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).