Github messages for voidlinux
 help / color / mirror / Atom feed
From: realcharmer <realcharmer@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] urh: update to 2.9.4
Date: Thu, 09 Feb 2023 19:05:14 +0100	[thread overview]
Message-ID: <20230209180514.I1KUXVZltC4y2Z07_DykkObSwC3Dw0jfyGOoPyGJTkk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42025@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

New review comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/42025#discussion_r1101845480

Comment:
The testsuite fails, but it seems like some libraries for `checkdepends` are missing? I am not sure it's a best practice to add `pip` as a dependency for check, but in the output seems to complain about that.

  parent reply	other threads:[~2023-02-09 18:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-02  8:17 [PR PATCH] " realcharmer
2023-02-05 10:43 ` [PR REVIEW] " paper42
2023-02-05 10:43 ` paper42
2023-02-05 10:43 ` paper42
2023-02-09 16:25 ` [PR PATCH] [Updated] " realcharmer
2023-02-09 16:39 ` realcharmer
2023-02-09 17:58 ` realcharmer
2023-02-09 18:05 ` realcharmer [this message]
2023-02-09 18:40 ` [PR REVIEW] " paper42
2023-02-09 21:00 ` [PR PATCH] [Updated] " realcharmer
2023-02-10  7:37 ` realcharmer
2023-02-10  7:38 ` [PR REVIEW] " realcharmer
2023-02-10 22:46 ` paper42
2023-02-20  7:55 ` [PR PATCH] [Updated] " realcharmer
2023-02-20  7:57 ` [PR REVIEW] " realcharmer
2023-02-20  7:57 ` realcharmer
2023-02-23 21:23 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230209180514.I1KUXVZltC4y2Z07_DykkObSwC3Dw0jfyGOoPyGJTkk@z \
    --to=realcharmer@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).