Github messages for voidlinux
 help / color / mirror / Atom feed
From: rvighne <rvighne@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] dnsmasq: enable dnssec build option by default
Date: Sun, 12 Feb 2023 21:30:22 +0100	[thread overview]
Message-ID: <20230212203022.OoHG11LQdhy5on5ob84p17AFTK9d-U0xhzdPzg3LLfE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41786@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

There is an updated pull request by rvighne against master on the void-packages repository

https://github.com/rvighne/void-packages dnsmasq/enable-dnssec
https://github.com/void-linux/void-packages/pull/41786

dnsmasq: enable dnssec build option by default
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl

#### Notes
I uncommented these lines in `/etc/dnsmasq.conf`;
```
conf-file=/usr/share/dnsmasq/trust-anchors.conf
dnssec
```

Logs show it worked:
```
DNSSEC validation enabled
configured with trust anchor for <root> keytag 20326
```

A patch file from https://github.com/void-linux/void-packages/pull/41786.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dnsmasq/enable-dnssec-41786.patch --]
[-- Type: text/x-diff, Size: 969 bytes --]

From 69b34e3349c074d98a097f8d1cc975832049eb6e Mon Sep 17 00:00:00 2001
From: Rohit Vighne <rohit.vighne@gmail.com>
Date: Fri, 20 Jan 2023 21:19:53 -0500
Subject: [PATCH] dnsmasq: enable dnssec build option by default

---
 srcpkgs/dnsmasq/template | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/srcpkgs/dnsmasq/template b/srcpkgs/dnsmasq/template
index b1c984f7dc4f..a11dd9f08e2a 100644
--- a/srcpkgs/dnsmasq/template
+++ b/srcpkgs/dnsmasq/template
@@ -16,6 +16,7 @@ system_accounts="dnsmasq"
 dnsmasq_homedir="/var/chroot"
 
 build_options="dnssec"
+build_options_default="dnssec"
 desc_option_dnssec="Enable DNSSEC support via nettle"
 
 do_build() {
@@ -31,6 +32,8 @@ do_install() {
 	make PREFIX=/usr BINDIR=/usr/bin DESTDIR=${DESTDIR} install
 
 	vsv dnsmasq
+	vsconf dnsmasq.conf.example dnsmasq.conf
 	vconf dnsmasq.conf.example dnsmasq.conf
 	vinstall ${FILESDIR}/dbus.conf 644 etc/dbus-1/system.d
+	vinstall trust-anchors.conf 644 usr/share/dnsmasq
 }

  parent reply	other threads:[~2023-02-12 20:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-21 21:49 [PR PATCH] " rvighne
2023-02-12 20:29 ` [PR PATCH] [Updated] " rvighne
2023-02-12 20:30 ` rvighne [this message]
2023-02-12 20:39 ` rvighne
2023-02-12 22:32 ` [PR REVIEW] " ahesford
2023-03-12 20:43 ` rvighne
2023-03-12 21:01 ` rvighne
2023-06-11  2:09 ` github-actions
2023-06-25  2:12 ` [PR PATCH] [Closed]: " github-actions
2023-06-25  2:14 ` [PR REVIEW] " abenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230212203022.OoHG11LQdhy5on5ob84p17AFTK9d-U0xhzdPzg3LLfE@z \
    --to=rvighne@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).