Github messages for voidlinux
 help / color / mirror / Atom feed
From: icp1994 <icp1994@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] python3-PyPDF2: rename to python3-pypdf, update to 3.4.0.
Date: Mon, 13 Feb 2023 20:59:39 +0100	[thread overview]
Message-ID: <20230213195939.59KAvenkk_ClUesJpw7HyNvWpssM5GZH5RdvT-OHpKc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42227@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/42227#discussion_r1104958801

Comment:
The link under the `About` section of https://github.com/py-pdf/pypdf contains the readthedocs site but with hardcoded language version. It's favorable to use rtfd as it will always redirect to the default version of the project whatever it might change to in the future: https://docs.readthedocs.io/en/stable/automatic-redirects.html#rtfd-io

  parent reply	other threads:[~2023-02-13 19:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-12 19:20 [PR PATCH] " icp1994
2023-02-13 19:39 ` [PR REVIEW] " Chocimier
2023-02-13 19:59 ` icp1994 [this message]
2023-02-13 20:16 ` Chocimier
2023-02-13 20:16 ` Chocimier
2023-02-14  4:52 ` [PR PATCH] [Updated] " icp1994
2023-02-14 19:19 ` [PR PATCH] [Merged]: python3-PyPDF2: rename to python3-pypdf, update to 3.4.1 Chocimier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230213195939.59KAvenkk_ClUesJpw7HyNvWpssM5GZH5RdvT-OHpKc@z \
    --to=icp1994@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).