From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: update-check shouldn't strip away pkgname prefixes when pkgname is set in the update file
Date: Sat, 18 Feb 2023 21:27:34 +0100 [thread overview]
Message-ID: <20230218202734.N8z67JR7Um9gdlgWFcFcDKEfXUCSllS6wwma2dvEqho@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42082@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/issues/42082#issuecomment-1435762498
Comment:
`if [ "$pkgname" != "$original_pkgname" ]; then pkgnameoverride=1; fi` doesn't work for just avoiding trimming, that is, final pkgname equal to pkgname in template.
Working solution would be to:
1. source `update` file second time in clean subshell and see if it sets any `pkgname`
2. add dedicated `no_trim_pkgname` variable
3. document setting dummy prefix, so it will be trimmed - python3-snappy sets `pkgname="python-python-snappy"` (my preferred)
next prev parent reply other threads:[~2023-02-18 20:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 22:25 [ISSUE] " paper42
2023-02-05 2:18 ` kruceter
2023-02-05 2:18 ` kruceter
2023-02-07 14:36 ` sgn
2023-02-18 20:27 ` Chocimier [this message]
2023-05-20 1:51 ` github-actions
2023-06-03 2:01 ` [ISSUE] [CLOSED] " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230218202734.N8z67JR7Um9gdlgWFcFcDKEfXUCSllS6wwma2dvEqho@z \
--to=chocimier@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).