Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: vivaldi: update to 5.7.2921.53
Date: Sun, 19 Feb 2023 05:21:15 +0100	[thread overview]
Message-ID: <20230219042115.MHidYZzcG9ibEPYAINAWBYbAKgzSgXN1u3K9HcNdbDE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42327@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42327#issuecomment-1435865936

Comment:
> The proposed solution is to put all QT functionality into a separate shared library called libqt5_shim.so whose sole purpose is to adapt the QT interface for Chrome.  libqt5_shim.so will depend on QT directly.  Then at runtime, Chrome can dlopen() libqt5_shim.so with RTLD_NOW and if QT is available the library will be loaded; otherwise dlopen() will fail, and will not cause a crash.

this tells me it should be fine to add the `skiprdeps` line. anyone who wants to use the qt integration (like KDE users) should already have the necessary qt components installed and the shim will load successfully. if not, it won't load successfully and it shouldn't cause any issues.

  parent reply	other threads:[~2023-02-19  4:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17 11:09 [PR PATCH] " rafeyu
2023-02-17 13:05 ` icp1994
2023-02-18  9:17 ` rafeyu
2023-02-19  4:21 ` classabbyamp [this message]
2023-02-19 14:49 ` [PR PATCH] [Updated] " rafeyu
2023-03-05  8:16 ` classabbyamp
2023-03-05  8:16 ` [PR PATCH] [Updated] " classabbyamp
2023-03-05  8:18 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230219042115.MHidYZzcG9ibEPYAINAWBYbAKgzSgXN1u3K9HcNdbDE@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).