From: steinex <steinex@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] i2pd: restrict /etc/i2pd permissions
Date: Thu, 23 Feb 2023 12:11:35 +0100 [thread overview]
Message-ID: <20230223111135.kNI-RWdUihOdPIJwu4ERiQTtxGxlVnWUNAHDSkWIZYo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42409@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]
There is an updated pull request by steinex against master on the void-packages repository
https://github.com/steinex/void-packages i2pd
https://github.com/void-linux/void-packages/pull/42409
i2pd: restrict /etc/i2pd permissions
It's not a good idea to have /etc/i2pd/*.conf world-readable since it may contain sensitive information
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/42409.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-i2pd-42409.patch --]
[-- Type: text/x-diff, Size: 1059 bytes --]
From e8d8d079d7ddec1df8530463fc3533b69047d2c2 Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Thu, 23 Feb 2023 12:00:26 +0100
Subject: [PATCH] i2pd: restrict /etc/i2pd permissions
It's not a good idea to have /etc/i2pd/*.conf world-readable since
it may contain sensitive information.
---
srcpkgs/i2pd/template | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/i2pd/template b/srcpkgs/i2pd/template
index 91e085f41aca..c79aefa38a0f 100644
--- a/srcpkgs/i2pd/template
+++ b/srcpkgs/i2pd/template
@@ -1,7 +1,7 @@
# Template file for 'i2pd'
pkgname=i2pd
version=2.46.0
-revision=1
+revision=2
build_style=gnu-makefile
make_build_args="USE_UPNP=yes"
makedepends="zlib-devel boost-devel openssl-devel miniupnpc-devel
@@ -19,7 +19,9 @@ conf_files="
/etc/i2pd/tunnels.conf"
system_accounts="_i2pd"
_i2pd_homedir="/var/lib/i2pd"
-make_dirs="/var/lib/i2pd 0700 _i2pd _i2pd"
+make_dirs="
+ /var/lib/i2pd 0700 _i2pd _i2pd
+ /etc/i2pd 0700 _i2pd _i2pd"
case "${XBPS_TARGET_MACHINE}" in
x86_64*) ;;
next prev parent reply other threads:[~2023-02-23 11:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 11:06 [PR PATCH] " steinex
2023-02-23 11:10 ` [PR PATCH] [Updated] " steinex
2023-02-23 11:11 ` steinex [this message]
2023-03-05 22:57 ` Duncaen
2023-03-05 22:58 ` Duncaen
2023-03-06 8:56 ` [PR PATCH] [Updated] " steinex
2023-03-06 9:08 ` steinex
2023-03-06 9:52 ` [PR PATCH] [Updated] " steinex
2023-05-25 16:29 ` [PR PATCH] [Merged]: " Duncaen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230223111135.kNI-RWdUihOdPIJwu4ERiQTtxGxlVnWUNAHDSkWIZYo@z \
--to=steinex@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).