[PR PATCH] urh: update to 2.9.4

[PR PATCH] urh: update to 2.9.4

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

There is a new pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages urh
https://github.com/void-linux/void-packages/pull/42025

urh: update to 2.9.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

A patch file from https://github.com/void-linux/void-packages/pull/42025.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-urh-42025.patch --]
[-- Type: text/x-diff, Size: 1035 bytes --]

From e3789d6446700a01b6e91b9c59240b7a3d88445d Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Thu, 2 Feb 2023 09:16:06 +0100
Subject: [PATCH] urh: update to 2.9.4

---
 srcpkgs/urh/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/urh/template b/srcpkgs/urh/template
index 72dd959825f4..40f83dd6a009 100644
--- a/srcpkgs/urh/template
+++ b/srcpkgs/urh/template
@@ -1,6 +1,6 @@
 # Template file for 'urh'
 pkgname=urh
-version=2.9.3
+version=2.9.4
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools python3-Cython python3-numpy"
@@ -13,7 +13,7 @@ maintainer="Emil Miler <em@0x45.cz>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/jopohl/urh"
 distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=a36dd3ff79f66cc0a746a0b57aaf278c86dda7c091a3b10682fe4fcaa7e91586
+checksum=d2d31df8819489910e95451dcb8faf3aa5c371da65bd9df3a4712e532186b67f
 make_check=no # tests/test_advanced_modulation_settings.py Aborted (core dumped)
 
 post_install() {

Re: [PR REVIEW] urh: update to 2.9.4

[paper42]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42025#discussion_r1096661505

Comment:
```suggestion
distfiles="https://github.com/jopohl/urh/archive/refs/tags/vv${version}.tar.gz"
```

Re: [PR REVIEW] urh: update to 2.9.4

[paper42]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42025#discussion_r1096661844

Comment:
if this is still happening, can we just disable the one test that's causing the issues or just remove this file and let the rest run?

Re: [PR REVIEW] urh: update to 2.9.4

[paper42]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42025#discussion_r1096661521

Comment:
```suggestion
homepage="https://github.com/jopohl/urh"
changelog="https://github.com/jopohl/urh/releases"
```

Re: [PR PATCH] [Updated] urh: update to 2.9.4

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

There is an updated pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages urh
https://github.com/void-linux/void-packages/pull/42025

urh: update to 2.9.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

A patch file from https://github.com/void-linux/void-packages/pull/42025.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-urh-42025.patch --]
[-- Type: text/x-diff, Size: 1303 bytes --]

From 2f6b29d671ade38157310d7cae883d1d46c2b889 Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Thu, 2 Feb 2023 09:16:06 +0100
Subject: [PATCH] urh: update to 2.9.4

---
 srcpkgs/urh/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/urh/template b/srcpkgs/urh/template
index 72dd959825f4..35a7c96d89dc 100644
--- a/srcpkgs/urh/template
+++ b/srcpkgs/urh/template
@@ -1,6 +1,6 @@
 # Template file for 'urh'
 pkgname=urh
-version=2.9.3
+version=2.9.4
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools python3-Cython python3-numpy"
@@ -12,9 +12,9 @@ short_desc="Universal Radio Hacker: investigate unknown wireless protocols"
 maintainer="Emil Miler <em@0x45.cz>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/jopohl/urh"
-distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=a36dd3ff79f66cc0a746a0b57aaf278c86dda7c091a3b10682fe4fcaa7e91586
-make_check=no # tests/test_advanced_modulation_settings.py Aborted (core dumped)
+changelog="https://github.com/jopohl/urh/releases"
+distfiles="https://github.com/jopohl/urh/archive/refs/tags/v${version}.tar.gz"
+checksum=d2d31df8819489910e95451dcb8faf3aa5c371da65bd9df3a4712e532186b67f
 
 post_install() {
 	vinstall data/urh.desktop 644 usr/share/applications

Re: [PR PATCH] [Updated] urh: update to 2.9.4

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

There is an updated pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages urh
https://github.com/void-linux/void-packages/pull/42025

urh: update to 2.9.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

A patch file from https://github.com/void-linux/void-packages/pull/42025.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-urh-42025.patch --]
[-- Type: text/x-diff, Size: 1527 bytes --]

From c97417dcc2b6205efa7b6b7e93847851c765fb3c Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Thu, 2 Feb 2023 09:16:06 +0100
Subject: [PATCH] urh: update to 2.9.4

---
 srcpkgs/urh/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/urh/template b/srcpkgs/urh/template
index 72dd959825f4..a91005afd595 100644
--- a/srcpkgs/urh/template
+++ b/srcpkgs/urh/template
@@ -1,20 +1,21 @@
 # Template file for 'urh'
 pkgname=urh
-version=2.9.3
+version=2.9.4
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools python3-Cython python3-numpy"
 makedepends="python3-devel python3-PyQt5 libairspy-devel librtlsdr-devel
  libhackrf-devel uhd-devel libgomp-devel"
+checkdepends="python3-pytest"
 depends="python3-numpy python3-PyQt5 python3-Cython python3-psutil
  python3-setuptools"
 short_desc="Universal Radio Hacker: investigate unknown wireless protocols"
 maintainer="Emil Miler <em@0x45.cz>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/jopohl/urh"
-distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=a36dd3ff79f66cc0a746a0b57aaf278c86dda7c091a3b10682fe4fcaa7e91586
-make_check=no # tests/test_advanced_modulation_settings.py Aborted (core dumped)
+changelog="https://github.com/jopohl/urh/releases"
+distfiles="https://github.com/jopohl/urh/archive/refs/tags/v${version}.tar.gz"
+checksum=d2d31df8819489910e95451dcb8faf3aa5c371da65bd9df3a4712e532186b67f
 
 post_install() {
 	vinstall data/urh.desktop 644 usr/share/applications

Re: [PR PATCH] [Updated] urh: update to 2.9.4

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

There is an updated pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages urh
https://github.com/void-linux/void-packages/pull/42025

urh: update to 2.9.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

A patch file from https://github.com/void-linux/void-packages/pull/42025.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-urh-42025.patch --]
[-- Type: text/x-diff, Size: 1303 bytes --]

From 94129b7b06e8461fd0c4f92b58a1ce910feb184d Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Thu, 2 Feb 2023 09:16:06 +0100
Subject: [PATCH] urh: update to 2.9.4

---
 srcpkgs/urh/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/urh/template b/srcpkgs/urh/template
index 72dd959825f4..35a7c96d89dc 100644
--- a/srcpkgs/urh/template
+++ b/srcpkgs/urh/template
@@ -1,6 +1,6 @@
 # Template file for 'urh'
 pkgname=urh
-version=2.9.3
+version=2.9.4
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools python3-Cython python3-numpy"
@@ -12,9 +12,9 @@ short_desc="Universal Radio Hacker: investigate unknown wireless protocols"
 maintainer="Emil Miler <em@0x45.cz>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/jopohl/urh"
-distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=a36dd3ff79f66cc0a746a0b57aaf278c86dda7c091a3b10682fe4fcaa7e91586
-make_check=no # tests/test_advanced_modulation_settings.py Aborted (core dumped)
+changelog="https://github.com/jopohl/urh/releases"
+distfiles="https://github.com/jopohl/urh/archive/refs/tags/v${version}.tar.gz"
+checksum=d2d31df8819489910e95451dcb8faf3aa5c371da65bd9df3a4712e532186b67f
 
 post_install() {
 	vinstall data/urh.desktop 644 usr/share/applications

Re: [PR REVIEW] urh: update to 2.9.4

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

New review comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/42025#discussion_r1101845480

Comment:
The testsuite fails, but it seems like some libraries for `checkdepends` are missing? I am not sure it's a best practice to add `pip` as a dependency for check, but in the output seems to complain about that.

Re: [PR REVIEW] urh: update to 2.9.4

[paper42]

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42025#discussion_r1101884899

Comment:
Adding pip to checkdepends only leads to it installing all dependencies it needs in the versions it needs with pip. We don't want that, but it's also not telling us pip is missing:
```
error: Command '['/usr/bin/python3', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmp6dbhqicv', '--quiet', 'psutil']' returned non-zero exit status 1.
```
If you read this carefully, it's telling us that psutil is missing. Most of these missing dependencies can be probably solved with a simple `checkdepends="$depends"`

Re: [PR PATCH] [Updated] urh: update to 2.9.4

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

There is an updated pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages urh
https://github.com/void-linux/void-packages/pull/42025

urh: update to 2.9.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

A patch file from https://github.com/void-linux/void-packages/pull/42025.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-urh-42025.patch --]
[-- Type: text/x-diff, Size: 1537 bytes --]

From 7475125ab2701af3eff891ad629ceecb2e813330 Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Thu, 2 Feb 2023 09:16:06 +0100
Subject: [PATCH] urh: update to 2.9.4

---
 srcpkgs/urh/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/urh/template b/srcpkgs/urh/template
index 72dd959825f4..c1904d204210 100644
--- a/srcpkgs/urh/template
+++ b/srcpkgs/urh/template
@@ -1,6 +1,6 @@
 # Template file for 'urh'
 pkgname=urh
-version=2.9.3
+version=2.9.4
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools python3-Cython python3-numpy"
@@ -8,13 +8,14 @@ makedepends="python3-devel python3-PyQt5 libairspy-devel librtlsdr-devel
  libhackrf-devel uhd-devel libgomp-devel"
 depends="python3-numpy python3-PyQt5 python3-Cython python3-psutil
  python3-setuptools"
+ checkdepends="$depends"
 short_desc="Universal Radio Hacker: investigate unknown wireless protocols"
 maintainer="Emil Miler <em@0x45.cz>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/jopohl/urh"
-distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=a36dd3ff79f66cc0a746a0b57aaf278c86dda7c091a3b10682fe4fcaa7e91586
-make_check=no # tests/test_advanced_modulation_settings.py Aborted (core dumped)
+changelog="https://github.com/jopohl/urh/releases"
+distfiles="https://github.com/jopohl/urh/archive/refs/tags/v${version}.tar.gz"
+checksum=d2d31df8819489910e95451dcb8faf3aa5c371da65bd9df3a4712e532186b67f
 
 post_install() {
 	vinstall data/urh.desktop 644 usr/share/applications

Re: [PR PATCH] [Updated] urh: update to 2.9.4

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

There is an updated pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages urh
https://github.com/void-linux/void-packages/pull/42025

urh: update to 2.9.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

A patch file from https://github.com/void-linux/void-packages/pull/42025.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-urh-42025.patch --]
[-- Type: text/x-diff, Size: 1536 bytes --]

From dc46682238f2a4c4c0883637aa220504fa727a12 Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Thu, 2 Feb 2023 09:16:06 +0100
Subject: [PATCH] urh: update to 2.9.4

---
 srcpkgs/urh/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/urh/template b/srcpkgs/urh/template
index 72dd959825f4..4ebc89d7be51 100644
--- a/srcpkgs/urh/template
+++ b/srcpkgs/urh/template
@@ -1,6 +1,6 @@
 # Template file for 'urh'
 pkgname=urh
-version=2.9.3
+version=2.9.4
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools python3-Cython python3-numpy"
@@ -8,13 +8,14 @@ makedepends="python3-devel python3-PyQt5 libairspy-devel librtlsdr-devel
  libhackrf-devel uhd-devel libgomp-devel"
 depends="python3-numpy python3-PyQt5 python3-Cython python3-psutil
  python3-setuptools"
+checkdepends="$depends"
 short_desc="Universal Radio Hacker: investigate unknown wireless protocols"
 maintainer="Emil Miler <em@0x45.cz>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/jopohl/urh"
-distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=a36dd3ff79f66cc0a746a0b57aaf278c86dda7c091a3b10682fe4fcaa7e91586
-make_check=no # tests/test_advanced_modulation_settings.py Aborted (core dumped)
+changelog="https://github.com/jopohl/urh/releases"
+distfiles="https://github.com/jopohl/urh/archive/refs/tags/v${version}.tar.gz"
+checksum=d2d31df8819489910e95451dcb8faf3aa5c371da65bd9df3a4712e532186b67f
 
 post_install() {
 	vinstall data/urh.desktop 644 usr/share/applications

Re: [PR REVIEW] urh: update to 2.9.4

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New review comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/42025#discussion_r1102383417

Comment:
Alright, makes sense. I originally thought the dependencies get installed from `makedepends` and tests are being run after that.

Re: [PR REVIEW] urh: update to 2.9.4

[paper42]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42025#discussion_r1103325560

Comment:
One of the tests is taking way too long and CI times out. It would be nice if we could figure out which one it is and disable it specifically, but disabling all tests and modifying the comment next to make_check=no to match reality would also be acceptable.

Re: [PR PATCH] [Updated] urh: update to 2.9.4

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

There is an updated pull request by realcharmer against master on the void-packages repository

https://github.com/realcharmer/void-packages urh
https://github.com/void-linux/void-packages/pull/42025

urh: update to 2.9.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

A patch file from https://github.com/void-linux/void-packages/pull/42025.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-urh-42025.patch --]
[-- Type: text/x-diff, Size: 1602 bytes --]

From e9c78171351da6026a27ee902cd04033623d7fa8 Mon Sep 17 00:00:00 2001
From: Emil Miler <em@0x45.cz>
Date: Thu, 2 Feb 2023 09:16:06 +0100
Subject: [PATCH] urh: update to 2.9.4

---
 srcpkgs/urh/template | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/urh/template b/srcpkgs/urh/template
index 72dd959825f4..045c82f6b3ad 100644
--- a/srcpkgs/urh/template
+++ b/srcpkgs/urh/template
@@ -1,6 +1,6 @@
 # Template file for 'urh'
 pkgname=urh
-version=2.9.3
+version=2.9.4
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools python3-Cython python3-numpy"
@@ -8,13 +8,15 @@ makedepends="python3-devel python3-PyQt5 libairspy-devel librtlsdr-devel
  libhackrf-devel uhd-devel libgomp-devel"
 depends="python3-numpy python3-PyQt5 python3-Cython python3-psutil
  python3-setuptools"
+checkdepends="$depends"
 short_desc="Universal Radio Hacker: investigate unknown wireless protocols"
 maintainer="Emil Miler <em@0x45.cz>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/jopohl/urh"
-distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=a36dd3ff79f66cc0a746a0b57aaf278c86dda7c091a3b10682fe4fcaa7e91586
-make_check=no # tests/test_advanced_modulation_settings.py Aborted (core dumped)
+changelog="https://github.com/jopohl/urh/releases"
+distfiles="https://github.com/jopohl/urh/archive/refs/tags/v${version}.tar.gz"
+checksum=d2d31df8819489910e95451dcb8faf3aa5c371da65bd9df3a4712e532186b67f
+make_check=no # Test suite is taking too long and CI times out
 
 post_install() {
 	vinstall data/urh.desktop 644 usr/share/applications

Re: [PR REVIEW] urh: update to 2.9.4

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

New review comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/42025#discussion_r1111590855

Comment:
Sorry for taking too long, I've had a lot of work lately. I'd rather have it updated quickly, so i disabled the tests entirely for now. I will try and debug it in the future.

Re: [PR REVIEW] urh: update to 2.9.4

[realcharmer]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

New review comment by realcharmer on void-packages repository

https://github.com/void-linux/void-packages/pull/42025#discussion_r1111590855

Comment:
Sorry for taking too long, I've had a lot of work lately. I'd rather have it updated quickly, so i disabled the tests entirely for now and will try and debug it in the future.

Re: [PR PATCH] [Merged]: urh: update to 2.9.4

[paper42]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

There's a merged pull request on the void-packages repository

urh: update to 2.9.4
https://github.com/void-linux/void-packages/pull/42025

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)