From: JamiKettunen <JamiKettunen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] ayatana-ido: Fix and enable running tests
Date: Sun, 26 Feb 2023 16:30:58 +0100 [thread overview]
Message-ID: <20230226153058.ARZj9c3Q206u-3-YlLYc97EpYRZrdD-sEfDb71Psspc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42461@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]
There is an updated pull request by JamiKettunen against master on the void-packages repository
https://github.com/JamiKettunen/void-packages ayatana-ido-tests
https://github.com/void-linux/void-packages/pull/42461
ayatana-ido: Fix and enable running tests
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/42461.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ayatana-ido-tests-42461.patch --]
[-- Type: text/x-diff, Size: 2513 bytes --]
From bffdc5d9bcc249aacf4f888dab7ff3c15c1a1039 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Sun, 26 Feb 2023 17:21:51 +0200
Subject: [PATCH] ayatana-ido: Fix and enable running tests
---
srcpkgs/ayatana-ido/patches/gtest.diff | 25 +++++++++++++++++++++++++
srcpkgs/ayatana-ido/template | 6 ++++--
2 files changed, 29 insertions(+), 2 deletions(-)
create mode 100644 srcpkgs/ayatana-ido/patches/gtest.diff
diff --git a/srcpkgs/ayatana-ido/patches/gtest.diff b/srcpkgs/ayatana-ido/patches/gtest.diff
new file mode 100644
index 000000000000..ecb79c08f86a
--- /dev/null
+++ b/srcpkgs/ayatana-ido/patches/gtest.diff
@@ -0,0 +1,25 @@
+https://github.com/AyatanaIndicators/ayatana-ido/pull/63
+---
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index bc4295f..7bbc464 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -9,7 +9,7 @@ endif(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)
+
+ # Options
+
+-option(ENABLE_TESTS "Enable all tests and checks" OFF)
++option(ENABLE_TESTS "Enable all tests and checks" ON)
+ option(ENABLE_COVERAGE "Enable coverage reports (includes enabling all tests and checks)" OFF)
+ option(ENABLE_WERROR "Treat all build warnings as errors" OFF)
+
+diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
+index 74a258f..28c5727 100644
+--- a/tests/CMakeLists.txt
++++ b/tests/CMakeLists.txt
+@@ -1,4 +1,4 @@
+-find_package(GMock)
++find_package(GTest REQUIRED)
+
+ # gtest-menuitems
+
diff --git a/srcpkgs/ayatana-ido/template b/srcpkgs/ayatana-ido/template
index 717ad5808405..d516ed347e5d 100644
--- a/srcpkgs/ayatana-ido/template
+++ b/srcpkgs/ayatana-ido/template
@@ -1,11 +1,12 @@
# Template file for 'ayatana-ido'
pkgname=ayatana-ido
version=0.9.2
-revision=1
+revision=2
build_helper="gir"
build_style=cmake
hostmakedepends="pkg-config gobject-introspection vala"
-makedepends="gtk+3-devel glib-devel"
+makedepends="gtk+3-devel glib-devel gtest-devel"
+checkdepends="xvfb-run"
short_desc="Ayatana Indicator Display Objects"
maintainer="tibequadorian <tibequadorian@posteo.de>"
license="LGPL-3.0-or-later"
@@ -13,6 +14,7 @@ homepage="https://ayatanaindicators.github.io/"
changelog="https://github.com/AyatanaIndicators/ayatana-ido/raw/main/ChangeLog"
distfiles="https://github.com/AyatanaIndicators/ayatana-ido/archive/${version}.tar.gz"
checksum=b166e7a160458e4a71f6086d2e4e97e18cf1ac584231a4b9f1f338914203884c
+make_check_pre="xvfb-run"
ayatana-ido-devel_package() {
short_desc+=" - development files"
next prev parent reply other threads:[~2023-02-26 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 15:27 [PR PATCH] " JamiKettunen
2023-02-26 15:30 ` JamiKettunen [this message]
2023-02-26 18:31 ` [PR PATCH] [Updated] " JamiKettunen
2023-02-27 12:37 ` [PR PATCH] [Updated] ayatana-ido: update to 0.9.3, enable tests JamiKettunen
2023-02-27 12:38 ` [PR PATCH] [Updated] Enable tests for ayatana-ido & libayatana-indicator JamiKettunen
2023-03-02 7:23 ` JamiKettunen
2023-03-02 17:58 ` [PR PATCH] [Merged]: " leahneukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230226153058.ARZj9c3Q206u-3-YlLYc97EpYRZrdD-sEfDb71Psspc@z \
--to=jamikettunen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).