From: mhmdanas <mhmdanas@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] libplacebo: update to 5.229.2
Date: Sun, 26 Feb 2023 19:04:24 +0100 [thread overview]
Message-ID: <20230226180424.Qy4rrS3nAYPLlauQVSiDRp6Z9kr3uQuBGDxPMgjU9OU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40807@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
New review comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/40807#discussion_r1118127524
Comment:
```suggestion
fi
if [ -n "$XBPS_CHECK_PKGS" ]; then
configure_args+=" -Dtests=true"
else
configure_args+=" -Dtests=false"
fi
```
(I like to add both branches just in case the default value of the option changes)
next prev parent reply other threads:[~2023-02-26 18:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 17:56 [PR PATCH] libplacebo: update to 5.229.1 mmnmnnmnmm
2022-11-27 18:06 ` [PR PATCH] [Updated] " mmnmnnmnmm
2022-11-27 18:08 ` mmnmnnmnmm
2022-12-18 16:54 ` mmnmnnmnmm
2023-02-18 12:38 ` mmnmnnmnmm
2023-02-26 18:04 ` mhmdanas [this message]
2023-02-26 18:04 ` [PR REVIEW] libplacebo: update to 5.229.2 mhmdanas
2023-02-26 18:04 ` mhmdanas
2023-02-26 18:09 ` mhmdanas
2023-02-26 18:33 ` mhmdanas
2023-05-28 2:00 ` github-actions
2023-06-11 2:09 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230226180424.Qy4rrS3nAYPLlauQVSiDRp6Z9kr3uQuBGDxPMgjU9OU@z \
--to=mhmdanas@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).