[PR PATCH] pam: fix libc check

[PR PATCH] pam: fix libc check

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages pam
https://github.com/void-linux/void-packages/pull/42535

pam: fix libc check
#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

This should be the actual check, right? Although I haven't built/tested it locally. Not even sure if it requires revbump; just making a PR for visibility.

A patch file from https://github.com/void-linux/void-packages/pull/42535.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pam-42535.patch --]
[-- Type: text/x-diff, Size: 950 bytes --]

From f14b1476d3cf2530762452c4309b091c99272a1b Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 2 Mar 2023 01:06:21 +0530
Subject: [PATCH] pam: fix libc check

---
 srcpkgs/pam/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/pam/template b/srcpkgs/pam/template
index 70d87f00af90..1b3c3c848b1f 100644
--- a/srcpkgs/pam/template
+++ b/srcpkgs/pam/template
@@ -1,7 +1,7 @@
 # Template file for 'pam'
 pkgname=pam
 version=1.5.2
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="
  --libdir=/usr/lib --sbindir=/usr/bin --docdir=/usr/share/doc/pam
@@ -32,7 +32,7 @@ distfiles="${homepage}/releases/download/v${version}/Linux-PAM-${version}.tar.xz
 checksum=e4ec7131a91da44512574268f493c6d8ca105c87091691b8e9b56ca685d4f94d
 lib32disabled=yes
 
-if [ "$XBPS_CHECK_PKGS" = musl ]; then
+if [ "$XBPS_TARGET_MACHINE" = musl ]; then
 	configure_args+=" ac_cv_search_crypt=no"
 fi
 

Re: [PR PATCH] [Updated] pam: fix libc check

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages pam
https://github.com/void-linux/void-packages/pull/42535

pam: fix libc check
#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

This should be the actual check, right? Although I haven't built/tested it locally. Not even sure if it requires revbump; just making a PR for visibility.

A patch file from https://github.com/void-linux/void-packages/pull/42535.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pam-42535.patch --]
[-- Type: text/x-diff, Size: 1275 bytes --]

From 77435d1160357fa47b116c835a979f6b01d0cbea Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 2 Mar 2023 01:06:21 +0530
Subject: [PATCH] pam: fix libc check

remove version from pam-base dependency.
---
 srcpkgs/pam/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/pam/template b/srcpkgs/pam/template
index 70d87f00af90..75487d63bb5a 100644
--- a/srcpkgs/pam/template
+++ b/srcpkgs/pam/template
@@ -1,7 +1,7 @@
 # Template file for 'pam'
 pkgname=pam
 version=1.5.2
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="
  --libdir=/usr/lib --sbindir=/usr/bin --docdir=/usr/share/doc/pam
@@ -10,7 +10,7 @@ configure_args="
 hostmakedepends="gettext-devel pkg-config"
 makedepends="libfl-devel db-devel"
 # version of pam-base that doesn't include removed modules
-depends="pam-base>=0.4_1"
+depends="pam-base"
 checkdepends="${depends}"
 conf_files="
 	/etc/environment
@@ -32,7 +32,7 @@ distfiles="${homepage}/releases/download/v${version}/Linux-PAM-${version}.tar.xz
 checksum=e4ec7131a91da44512574268f493c6d8ca105c87091691b8e9b56ca685d4f94d
 lib32disabled=yes
 
-if [ "$XBPS_CHECK_PKGS" = musl ]; then
+if [ "$XBPS_TARGET_MACHINE" = musl ]; then
 	configure_args+=" ac_cv_search_crypt=no"
 fi
 

Re: [PR PATCH] [Updated] pam: fix libc check

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages pam
https://github.com/void-linux/void-packages/pull/42535

pam: fix libc check
#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

This should be the actual check, right? Although I haven't built/tested it locally. Not even sure if it requires revbump; just making a PR for visibility.

A patch file from https://github.com/void-linux/void-packages/pull/42535.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pam-42535.patch --]
[-- Type: text/x-diff, Size: 1272 bytes --]

From 5a4186d0ae6984f6dc5efd46e12ec7b5b646fadc Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 2 Mar 2023 01:06:21 +0530
Subject: [PATCH] pam: fix libc check

remove version from pam-base dependency.
---
 srcpkgs/pam/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/pam/template b/srcpkgs/pam/template
index 70d87f00af90..567e7016428b 100644
--- a/srcpkgs/pam/template
+++ b/srcpkgs/pam/template
@@ -1,7 +1,7 @@
 # Template file for 'pam'
 pkgname=pam
 version=1.5.2
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="
  --libdir=/usr/lib --sbindir=/usr/bin --docdir=/usr/share/doc/pam
@@ -10,7 +10,7 @@ configure_args="
 hostmakedepends="gettext-devel pkg-config"
 makedepends="libfl-devel db-devel"
 # version of pam-base that doesn't include removed modules
-depends="pam-base>=0.4_1"
+depends="pam-base"
 checkdepends="${depends}"
 conf_files="
 	/etc/environment
@@ -32,7 +32,7 @@ distfiles="${homepage}/releases/download/v${version}/Linux-PAM-${version}.tar.xz
 checksum=e4ec7131a91da44512574268f493c6d8ca105c87091691b8e9b56ca685d4f94d
 lib32disabled=yes
 
-if [ "$XBPS_CHECK_PKGS" = musl ]; then
+if [ "$XBPS_TARGET_LIBC" = musl ]; then
 	configure_args+=" ac_cv_search_crypt=no"
 fi
 

Re: [PR PATCH] [Updated] pam: fix libc check

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages pam
https://github.com/void-linux/void-packages/pull/42535

pam: fix libc check
#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

This should be the actual check, right? Although I haven't built/tested it locally. Not even sure if it requires revbump; just making a PR for visibility.

A patch file from https://github.com/void-linux/void-packages/pull/42535.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pam-42535.patch --]
[-- Type: text/x-diff, Size: 1287 bytes --]

From b5e10b6944719826aebf86df78302a28583e0019 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 2 Mar 2023 01:06:21 +0530
Subject: [PATCH] pam: fix libc check

remove version from pam-base dependency.
---
 srcpkgs/pam/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/pam/template b/srcpkgs/pam/template
index 70d87f00af90..aad70a44ea28 100644
--- a/srcpkgs/pam/template
+++ b/srcpkgs/pam/template
@@ -1,7 +1,7 @@
 # Template file for 'pam'
 pkgname=pam
 version=1.5.2
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="
  --libdir=/usr/lib --sbindir=/usr/bin --docdir=/usr/share/doc/pam
@@ -11,7 +11,7 @@ hostmakedepends="gettext-devel pkg-config"
 makedepends="libfl-devel db-devel"
 # version of pam-base that doesn't include removed modules
 depends="pam-base>=0.4_1"
-checkdepends="${depends}"
+checkdepends="pam-base"
 conf_files="
 	/etc/environment
 	/etc/security/access.conf
@@ -32,7 +32,7 @@ distfiles="${homepage}/releases/download/v${version}/Linux-PAM-${version}.tar.xz
 checksum=e4ec7131a91da44512574268f493c6d8ca105c87091691b8e9b56ca685d4f94d
 lib32disabled=yes
 
-if [ "$XBPS_CHECK_PKGS" = musl ]; then
+if [ "$XBPS_TARGET_LIBC" = musl ]; then
 	configure_args+=" ac_cv_search_crypt=no"
 fi
 

Re: pam: fix libc check

[paper42]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42535#issuecomment-1456895351

Comment:
Nice find, but since this package has been working fine on musl even when the condition was always false on the builders, do you think we could just remove it? What was it supposed to achieve? cc @ericonr this commit broke the condition: 245d4a5ed7d09310de6eb8801adb5e571c03324b, this commit introduced the condition: 14902a61e6329de22d8c7b62f395a79c542221aa

Re: pam: fix libc check

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/42535#issuecomment-1456916154

Comment:
> do you think we could just remove it?

Someone with a -musl system have to answer that I think but seems like yes if it hasn't caused an issue all this time.

Re: pam: fix libc check

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/42535#issuecomment-1575930563

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: pam: fix libc check

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

There's a closed pull request on the void-packages repository

pam: fix libc check
https://github.com/void-linux/void-packages/pull/42535

Description:
#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

This should be the actual check, right? Although I haven't built/tested it locally. Not even sure if it requires revbump; just making a PR for visibility.