Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] dracut: remove ifcfg dracut module
@ 2023-03-02  2:48 LaszloGombos
  2023-03-02  2:49 ` LaszloGombos
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: LaszloGombos @ 2023-03-02  2:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

There is a new pull request by LaszloGombos against master on the void-packages repository

https://github.com/LaszloGombos/void-packages master
https://github.com/void-linux/void-packages/pull/42539

dracut: remove ifcfg dracut module
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**


A patch file from https://github.com/void-linux/void-packages/pull/42539.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-42539.patch --]
[-- Type: text/x-diff, Size: 724 bytes --]

From 85901bf72ddeee0d67c61619e0def8acc0dfa872 Mon Sep 17 00:00:00 2001
From: Laszlo Gombos <laszlo.gombos@gmail.com>
Date: Thu, 2 Mar 2023 02:46:36 +0000
Subject: [PATCH] dracut: remove ifcfg dracut module

---
 srcpkgs/dracut/template | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/srcpkgs/dracut/template b/srcpkgs/dracut/template
index 52a0c38c91c8..b1ffb0db70c2 100644
--- a/srcpkgs/dracut/template
+++ b/srcpkgs/dracut/template
@@ -64,6 +64,9 @@ post_install() {
 		rm -r ${DESTDIR}/usr/lib/dracut/modules.d/${f}
 	done
 
+	# ifcfg network-scripts dependent (RHEL-derived)
+	rm -r ${DESTDIR}/usr/lib/dracut/modules.d/45ifcfg
+
 	rm ${DESTDIR}/usr/share/man/man8/*.service.*
 	rm -r ${DESTDIR}/usr/lib/kernel
 }

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: dracut: remove ifcfg dracut module
  2023-03-02  2:48 [PR PATCH] dracut: remove ifcfg dracut module LaszloGombos
@ 2023-03-02  2:49 ` LaszloGombos
  2023-03-02  2:49 ` LaszloGombos
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: LaszloGombos @ 2023-03-02  2:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New comment by LaszloGombos on void-packages repository

https://github.com/void-linux/void-packages/pull/42539#issuecomment-1451192603

Comment:
Follow-up on https://github.com/void-linux/void-packages/pull/41716#issuecomment-1451141356

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: dracut: remove ifcfg dracut module
  2023-03-02  2:48 [PR PATCH] dracut: remove ifcfg dracut module LaszloGombos
  2023-03-02  2:49 ` LaszloGombos
@ 2023-03-02  2:49 ` LaszloGombos
  2023-03-02  4:46 ` [PR PATCH] [Updated] " LaszloGombos
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: LaszloGombos @ 2023-03-02  2:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New comment by LaszloGombos on void-packages repository

https://github.com/void-linux/void-packages/pull/42539#issuecomment-1451192603

Comment:
Follow-up on https://github.com/void-linux/void-packages/pull/41716#issuecomment-1451141356

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] dracut: remove ifcfg dracut module
  2023-03-02  2:48 [PR PATCH] dracut: remove ifcfg dracut module LaszloGombos
  2023-03-02  2:49 ` LaszloGombos
  2023-03-02  2:49 ` LaszloGombos
@ 2023-03-02  4:46 ` LaszloGombos
  2023-03-02 15:25 ` LaszloGombos
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: LaszloGombos @ 2023-03-02  4:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

There is an updated pull request by LaszloGombos against master on the void-packages repository

https://github.com/LaszloGombos/void-packages master
https://github.com/void-linux/void-packages/pull/42539

dracut: remove ifcfg dracut module
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

Follow-up to https://github.com/void-linux/void-packages/pull/41716#issuecomment-1451141356


A patch file from https://github.com/void-linux/void-packages/pull/42539.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-42539.patch --]
[-- Type: text/x-diff, Size: 944 bytes --]

From 1aa2faef810824fb36c265bf2514c469ba8879bb Mon Sep 17 00:00:00 2001
From: Laszlo Gombos <laszlo.gombos@gmail.com>
Date: Thu, 2 Mar 2023 02:46:36 +0000
Subject: [PATCH] dracut: remove ifcfg dracut module

---
 srcpkgs/dracut/template | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/dracut/template b/srcpkgs/dracut/template
index 52a0c38c91c8..d4c7ec89045c 100644
--- a/srcpkgs/dracut/template
+++ b/srcpkgs/dracut/template
@@ -1,7 +1,7 @@
 # Template file for 'dracut'
 pkgname=dracut
 version=059
-revision=2
+revision=3
 build_style=configure
 configure_args="--prefix=/usr --sysconfdir=/etc"
 conf_files="/etc/dracut.conf"
@@ -64,6 +64,9 @@ post_install() {
 		rm -r ${DESTDIR}/usr/lib/dracut/modules.d/${f}
 	done
 
+	# ifcfg network-scripts dependent (RHEL-derived)
+	rm -r ${DESTDIR}/usr/lib/dracut/modules.d/45ifcfg
+
 	rm ${DESTDIR}/usr/share/man/man8/*.service.*
 	rm -r ${DESTDIR}/usr/lib/kernel
 }

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] dracut: remove ifcfg dracut module
  2023-03-02  2:48 [PR PATCH] dracut: remove ifcfg dracut module LaszloGombos
                   ` (2 preceding siblings ...)
  2023-03-02  4:46 ` [PR PATCH] [Updated] " LaszloGombos
@ 2023-03-02 15:25 ` LaszloGombos
  2023-03-02 15:42 ` zdykstra
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: LaszloGombos @ 2023-03-02 15:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

There is an updated pull request by LaszloGombos against master on the void-packages repository

https://github.com/LaszloGombos/void-packages master
https://github.com/void-linux/void-packages/pull/42539

dracut: remove ifcfg dracut module
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

Follow-up to https://github.com/void-linux/void-packages/pull/41716#issuecomment-1451141356


A patch file from https://github.com/void-linux/void-packages/pull/42539.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-42539.patch --]
[-- Type: text/x-diff, Size: 1876 bytes --]

From 2c63ac93b01a447539569cfe5acb7e303a17de65 Mon Sep 17 00:00:00 2001
From: Laszlo Gombos <laszlo.gombos@gmail.com>
Date: Thu, 2 Mar 2023 02:46:36 +0000
Subject: [PATCH] dracut: remove ifcfg dracut module

Other changes:
 - remove connman as it depends on systemd
 - move more network dependent modules to dracut-network package
---
 srcpkgs/dracut/template | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/dracut/template b/srcpkgs/dracut/template
index 52a0c38c91c8..436a6e29b156 100644
--- a/srcpkgs/dracut/template
+++ b/srcpkgs/dracut/template
@@ -1,7 +1,7 @@
 # Template file for 'dracut'
 pkgname=dracut
 version=059
-revision=2
+revision=3
 build_style=configure
 configure_args="--prefix=/usr --sysconfdir=/etc"
 conf_files="/etc/dracut.conf"
@@ -52,7 +52,7 @@ post_install() {
 
 	# systemd dependent additional dracut modules
 	for f in 06rngd 06dbus-broker 06dbus-daemon 09dbus \
-		35network-manager 35network-wicked 80lvmmerge \
+		35connman 35network-manager 35network-wicked 80lvmmerge \
 		99memstrack 99squash; do
 		rm -r ${DESTDIR}/usr/lib/dracut/modules.d/${f}
 	done
@@ -64,6 +64,9 @@ post_install() {
 		rm -r ${DESTDIR}/usr/lib/dracut/modules.d/${f}
 	done
 
+	# ifcfg network-scripts dependent (RHEL-derived)
+	rm -r ${DESTDIR}/usr/lib/dracut/modules.d/45ifcfg
+
 	rm ${DESTDIR}/usr/share/man/man8/*.service.*
 	rm -r ${DESTDIR}/usr/lib/kernel
 }
@@ -72,8 +75,9 @@ dracut-network_package() {
 	depends="dhclient ${sourcepkg}-${version}_${revision}"
 	short_desc+=" - network modules"
 	pkg_install() {
-		for f in 35network-legacy 40network 90livenet \
-			95fcoe 95iscsi 95nbd 95nfs; do
+		for f in 35network-legacy 40network 45url-lib \
+			90kernel-network-modules 90qemu-net 90livenet \
+			95cifs 95fcoe 95fcoe-uefi 95iscsi 95nbd 95nfs 95ssh-client; do
 			vmove usr/lib/dracut/modules.d/${f}
 		done
 	}

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: dracut: remove ifcfg dracut module
  2023-03-02  2:48 [PR PATCH] dracut: remove ifcfg dracut module LaszloGombos
                   ` (3 preceding siblings ...)
  2023-03-02 15:25 ` LaszloGombos
@ 2023-03-02 15:42 ` zdykstra
  2023-03-18  2:20 ` LaszloGombos
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: zdykstra @ 2023-03-02 15:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/42539#issuecomment-1452079854

Comment:
I should be able to test this tonight. On the surface, though, this looks fine.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: dracut: remove ifcfg dracut module
  2023-03-02  2:48 [PR PATCH] dracut: remove ifcfg dracut module LaszloGombos
                   ` (4 preceding siblings ...)
  2023-03-02 15:42 ` zdykstra
@ 2023-03-18  2:20 ` LaszloGombos
  2023-03-31 15:28 ` zdykstra
  2023-05-06 14:08 ` [PR PATCH] [Merged]: " classabbyamp
  7 siblings, 0 replies; 9+ messages in thread
From: LaszloGombos @ 2023-03-18  2:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by LaszloGombos on void-packages repository

https://github.com/void-linux/void-packages/pull/42539#issuecomment-1474610869

Comment:
What is the next step for the PR ? Thanks !

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: dracut: remove ifcfg dracut module
  2023-03-02  2:48 [PR PATCH] dracut: remove ifcfg dracut module LaszloGombos
                   ` (5 preceding siblings ...)
  2023-03-18  2:20 ` LaszloGombos
@ 2023-03-31 15:28 ` zdykstra
  2023-05-06 14:08 ` [PR PATCH] [Merged]: " classabbyamp
  7 siblings, 0 replies; 9+ messages in thread
From: zdykstra @ 2023-03-31 15:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/42539#issuecomment-1492131215

Comment:
This should be ready to merge whenever someone gets the appetite to do it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Merged]: dracut: remove ifcfg dracut module
  2023-03-02  2:48 [PR PATCH] dracut: remove ifcfg dracut module LaszloGombos
                   ` (6 preceding siblings ...)
  2023-03-31 15:28 ` zdykstra
@ 2023-05-06 14:08 ` classabbyamp
  7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2023-05-06 14:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

There's a merged pull request on the void-packages repository

dracut: remove ifcfg dracut module
https://github.com/void-linux/void-packages/pull/42539

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

Follow-up to https://github.com/void-linux/void-packages/pull/41716#issuecomment-1451141356

Other changes:
 - remove connman as it depends on systemd
 - move more network dependent modules to dracut-network package
 
 CC @zdykstra @classabbyamp 


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-05-06 14:08 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-02  2:48 [PR PATCH] dracut: remove ifcfg dracut module LaszloGombos
2023-03-02  2:49 ` LaszloGombos
2023-03-02  2:49 ` LaszloGombos
2023-03-02  4:46 ` [PR PATCH] [Updated] " LaszloGombos
2023-03-02 15:25 ` LaszloGombos
2023-03-02 15:42 ` zdykstra
2023-03-18  2:20 ` LaszloGombos
2023-03-31 15:28 ` zdykstra
2023-05-06 14:08 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).