From: mhmdanas <mhmdanas@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] i3blocks: adopt
Date: Thu, 02 Mar 2023 11:34:03 +0100 [thread overview]
Message-ID: <20230302103403.d1gdOLD1CxPrG73oIOr1gp_9hfAcwGzuqItI5wImj80@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42439@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
New review comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/42439#discussion_r1122892294
Comment:
It's kind of the new (semi-)official convention to avoid using any variables other than `version` (or related variables) in `distfiles`. For example, see the commit description in https://git.vuxu.org/xtools/commit/?id=248be132dff32a1d2ec45dce0c84f878fe8fdc51:
> It also often doesn't save any characters and not using the variable
> makes prettier, simpler URLs that can often be copied from the template
> without manually replacing variables to get to the page with sources.
The commit message is referring to `${pkgname}`, but the same idea applies to `${homepage}` too.
next prev parent reply other threads:[~2023-03-02 10:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 4:55 [PR PATCH] " carvalhudo
2023-02-25 5:02 ` [PR PATCH] [Updated] " carvalhudo
2023-02-25 5:04 ` carvalhudo
2023-02-25 19:12 ` [PR REVIEW] " mhmdanas
2023-03-01 23:17 ` carvalhudo
2023-03-02 5:00 ` carvalhudo
2023-03-02 10:34 ` mhmdanas [this message]
2023-03-05 19:08 ` [PR PATCH] [Updated] " carvalhudo
2023-03-05 19:09 ` [PR REVIEW] " carvalhudo
2023-03-11 7:30 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302103403.d1gdOLD1CxPrG73oIOr1gp_9hfAcwGzuqItI5wImj80@z \
--to=mhmdanas@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).