Github messages for voidlinux
 help / color / mirror / Atom feed
From: lemmi <lemmi@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: passt-2023.02.27.c538ee8
Date: Thu, 02 Mar 2023 20:14:38 +0100	[thread overview]
Message-ID: <20230302191438.rVWXLF8D0Tl86MiwQfcg9ky3nyAIwJqL3_r4cSuaSsw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42517@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/42517#issuecomment-1452423139

Comment:
Added the patch from <https://bugs.passt.top/show_bug.cgi?id=4#c1>. With that it compiled on `musl`, but broke `glibc`. Here's the fix:
```diff
--- musl.patch	2023-03-02 20:11:41.273250878 +0100
+++ musl-limits.patch	2023-03-02 20:12:16.791228390 +0100
@@ -41,7 +41,7 @@

  #include <stdbool.h>
 -
-+#include <bits/limits.h>
++#include <limits.h>
  #include "packet.h"
  #include "icmp.h"
  #include "port_fwd.h"
```
This is looking promising. Looks to me we can afford to wait for `musl` support to land. I'll keep an eye on the bugzilla and mailinglist.

  parent reply	other threads:[~2023-03-02 19:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01  4:07 [PR PATCH] " lemmi
2023-03-01 15:32 ` [PR REVIEW] " sgn
2023-03-01 17:28 ` lemmi
2023-03-02  0:07 ` sbrivio-rh
2023-03-02  0:33 ` lemmi
2023-03-02  8:58 ` sbrivio-rh
2023-03-02 13:53 ` sbrivio-rh
2023-03-02 19:11 ` [PR PATCH] [Updated] " lemmi
2023-03-02 19:14 ` lemmi [this message]
2023-03-02 19:15 ` lemmi
2023-03-09  9:15 ` sbrivio-rh
2023-03-10  3:12 ` [PR PATCH] [Updated] " lemmi
2023-03-19  6:38 ` [PR PATCH] [Updated] New package: passt-2023.03.09.7c7625d lemmi
2023-03-24 14:09 ` lemmi
2023-03-24 14:12 ` [PR PATCH] [Merged]: " lemmi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230302191438.rVWXLF8D0Tl86MiwQfcg9ky3nyAIwJqL3_r4cSuaSsw@z \
    --to=lemmi@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).