Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] ol: update to 2.4.
Date: Mon, 06 Mar 2023 19:37:07 +0100	[thread overview]
Message-ID: <20230306183707.GExNN7VELfXE8D680GSsTIkdTDc1gAMmra7Woa6nAtA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42590@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42590#discussion_r1126869716

Comment:
> why? that's an important line with build options to not be lost inside urls and descriptions.
imho.

because that's what the style is. by putting it not in the first block xlint doesn't catch it but that's where it should go

> Builders do not include ''armv5te and armv5tel, armv6hf, armv7hf, mips,mipshf, mipsel, mipselhf, ppc and ppc64".

because these aren't currently supported archs. the profiles exist but we don't really support them

  parent reply	other threads:[~2023-03-06 18:37 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-04 21:20 [PR PATCH] " yuriy-chumak
2023-03-04 22:26 ` [PR PATCH] [Updated] " yuriy-chumak
2023-03-04 23:45 ` yuriy-chumak
2023-03-05  1:16 ` yuriy-chumak
2023-03-05  1:31 ` yuriy-chumak
2023-03-05  1:36 ` yuriy-chumak
2023-03-05  1:45 ` yuriy-chumak
2023-03-05  2:08 ` yuriy-chumak
2023-03-05  2:22 ` yuriy-chumak
2023-03-05 19:54 ` [PR REVIEW] " icp1994
2023-03-05 19:54 ` icp1994
2023-03-05 19:54 ` icp1994
2023-03-06 16:32 ` yuriy-chumak
2023-03-06 16:42 ` [PR PATCH] [Updated] " yuriy-chumak
2023-03-06 16:46 ` [PR REVIEW] " yuriy-chumak
2023-03-06 17:10 ` [PR PATCH] [Updated] " yuriy-chumak
2023-03-06 17:42 ` [PR REVIEW] " classabbyamp
2023-03-06 17:50 ` yuriy-chumak
2023-03-06 17:51 ` yuriy-chumak
2023-03-06 17:56 ` yuriy-chumak
2023-03-06 17:58 ` yuriy-chumak
2023-03-06 18:06 ` yuriy-chumak
2023-03-06 18:37 ` classabbyamp [this message]
2023-03-06 20:25 ` yuriy-chumak
2023-03-06 20:33 ` [PR PATCH] [Updated] " yuriy-chumak
2023-03-06 20:39 ` [PR REVIEW] " yuriy-chumak
2023-03-06 21:05 ` yuriy-chumak
2023-03-08 15:50 ` [PR PATCH] [Merged]: " leahneukirchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230306183707.GExNN7VELfXE8D680GSsTIkdTDc1gAMmra7Woa6nAtA@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).