From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC] [WIP] use bash arrays for some template fields
Date: Wed, 08 Mar 2023 19:02:22 +0100 [thread overview]
Message-ID: <20230308180222.ipnQvyaiH_Ym0xhKs7YTy9yIEeemnWtjIS9z6cAaR58@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42656@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/42656#issuecomment-1460610011
Comment:
this might be for another issue/PR, but we might also want to consider using associative arrays for build_options like this:
```
declare -A buildopts=([docs]=0 [wayland]=1 [xorg]=1)
```
if this was declared before buildopts are used (= usually before configure_args), we could parse the template only once instead of twice if we also used functions for accessing build options instead of variables like currently (because buildopts has to be combined with options from cli args and the config). The only disadvantage I can think of is that it would be ugly to have declare -A right at the top of the template.
next prev parent reply other threads:[~2023-03-08 18:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 9:48 [PR PATCH] " classabbyamp
2023-03-08 10:00 ` tranzystorek-io
2023-03-08 10:03 ` tranzystorek-io
2023-03-08 10:09 ` tranzystorek-io
2023-03-08 10:11 ` classabbyamp
2023-03-08 10:12 ` classabbyamp
2023-03-08 10:17 ` tranzystorek-io
2023-03-08 11:41 ` [PR REVIEW] " ahesford
2023-03-08 12:26 ` leahneukirchen
2023-03-08 18:02 ` paper42 [this message]
2023-03-08 18:12 ` classabbyamp
2023-03-09 5:43 ` [PR REVIEW] " classabbyamp
2023-03-09 5:44 ` [PR PATCH] [Updated] " classabbyamp
2023-03-09 5:45 ` classabbyamp
2023-03-09 12:40 ` [PR REVIEW] " leahneukirchen
2023-03-09 12:42 ` leahneukirchen
2023-03-09 12:42 ` leahneukirchen
2023-03-09 12:43 ` leahneukirchen
2023-03-09 16:14 ` classabbyamp
2023-03-09 16:22 ` Duncaen
2023-03-09 16:37 ` [PR PATCH] [Updated] " classabbyamp
2023-03-09 16:38 ` classabbyamp
2023-03-09 16:38 ` classabbyamp
2023-06-08 2:05 ` github-actions
2023-06-08 2:35 ` classabbyamp
2023-09-07 1:44 ` github-actions
2023-09-07 1:55 ` classabbyamp
2023-11-02 13:42 ` [PR PATCH] [Updated] " classabbyamp
2023-11-02 15:54 ` classabbyamp
2023-11-02 15:56 ` classabbyamp
2023-11-02 16:31 ` [PR PATCH] [Updated] " classabbyamp
2023-11-02 16:44 ` classabbyamp
2024-02-01 1:45 ` github-actions
2024-03-17 2:13 ` [PR PATCH] [Updated] " classabbyamp
2024-03-17 2:31 ` classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308180222.ipnQvyaiH_Ym0xhKs7YTy9yIEeemnWtjIS9z6cAaR58@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).