From: hervyqa <hervyqa@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: rstudio: update to 2022.12.0+353
Date: Thu, 09 Mar 2023 16:49:27 +0100 [thread overview]
Message-ID: <20230309154927.arYQAsisPRY4xrye6-KkN5UuXsHTdW5-wCDU2gp3n5o@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42674@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]
New comment by hervyqa on void-packages repository
https://github.com/void-linux/void-packages/pull/42674#issuecomment-1462294868
Comment:
error build x86_64-musl.
```
/builddir/rstudio-2022.12.0+353/src/cpp/desktop/DesktopMain.cpp:656:33: error: 'gnu_get_libc_version' was not declared in this scope
656 | const char* libcVersion = gnu_get_libc_version();
| ^~~~~~~~~~~~~~~~~~~~
[295/616] Building CXX object src/cpp/desktop/CMakeFiles/rstudio.dir/DesktopMainWindow.cpp.o
ninja: build stopped: subcommand failed.
```
i don't understand how to solve this in musl. https://github.com/rstudio/rstudio/blob/ee56d49b0fca5f3d7c3f5214a4010355d1bb0212/src/cpp/desktop/DesktopMain.cpp#L656
```cpp
// newer versions of glibc require us to disable the seccomp filter
// sandbox, as the sandbox included with the version of chromium bundled
// with Qt 5.12.x does not play well with newer versions of glibc.
//
// the seccomp filter sandbox is used to prevent user-mode applications
// from executing potentially malicious system calls; however, it doesn't
// understand some of the newer syscalls introduced in newer versions of
// Linux (and used by newer versions of glibc)
const char* libcVersion = gnu_get_libc_version();
if (core::Version(libcVersion) >= core::Version("2.34"))
arguments.push_back(disableSeccompFilterSandbox);
```
cc maintainer: @Johnnynator
next prev parent reply other threads:[~2023-03-09 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 13:28 [PR PATCH] (WIP) " hervyqa
2023-03-09 15:49 ` hervyqa [this message]
2023-03-09 20:21 ` Johnnynator
2023-03-10 3:04 ` [PR PATCH] [Updated] " hervyqa
2023-03-10 4:14 ` hervyqa
2023-06-09 2:06 ` github-actions
2023-06-16 6:22 ` [PR PATCH] [Updated] " hervyqa
2023-09-16 1:44 ` github-actions
2023-09-30 1:44 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309154927.arYQAsisPRY4xrye6-KkN5UuXsHTdW5-wCDU2gp3n5o@z \
--to=hervyqa@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).