From: mhmdanas <mhmdanas@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] gnumeric: remove useless vsed.
Date: Thu, 09 Mar 2023 19:26:55 +0100 [thread overview]
Message-ID: <20230309182655.16ygOHvfOPcrWDsBartzaOss4QV9UdMrdsp2htVEvUk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42678@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
There is an updated pull request by mhmdanas against master on the void-packages repository
https://github.com/mhmdanas/void-packages gnumeric-remove-useless-vsed
https://github.com/void-linux/void-packages/pull/42678
gnumeric: remove useless vsed.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
@Duncaen
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/42678.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnumeric-remove-useless-vsed-42678.patch --]
[-- Type: text/x-diff, Size: 1235 bytes --]
From 8d1d0729a27fd8ce31d431a85ef98aa78822fe83 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 9 Mar 2023 17:41:33 +0000
Subject: [PATCH] gnumeric: remove useless vsed.
---
srcpkgs/gnumeric/template | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/gnumeric/template b/srcpkgs/gnumeric/template
index bb5db0bfb433..e4bdab9765df 100644
--- a/srcpkgs/gnumeric/template
+++ b/srcpkgs/gnumeric/template
@@ -12,6 +12,8 @@ homepage="http://gnumeric.org/"
changelog="https://github.com/GNOME/gnumeric/raw/master/NEWS"
distfiles="${GNOME_SITE}/gnumeric/${version%.*}/gnumeric-${version}.tar.xz"
checksum=c69a09cd190b622acca476bbc3d4c03d68d7ccf59bba61bf036ce60885f9fb65
+# FIXME: many tests fail.
+make_check=no
# This isn't a direct dependency but when soname bumping perl it will
# cause build failures
@@ -22,12 +24,8 @@ if [ "$CROSS_BUILD" ]; then
configure_args+=" --without-perl"
fi
-post_patch() {
- vsed -i -e 's/DATADIRNAME=lib/DATADIRNAME=share/' configure
-}
-
gnumeric-devel_package() {
- depends="gnumeric>=${version}_${revision}"
+ depends="${sourcepkg}>=${version}_${revision}"
short_desc+=" - development files"
pkg_install() {
vmove usr/include
next prev parent reply other threads:[~2023-03-09 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 18:00 [PR PATCH] " mhmdanas
2023-03-09 18:26 ` mhmdanas [this message]
2023-03-11 7:28 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309182655.16ygOHvfOPcrWDsBartzaOss4QV9UdMrdsp2htVEvUk@z \
--to=mhmdanas@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).