From: astralchan <astralchan@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] jamulus: update to 3.9.1
Date: Sun, 12 Mar 2023 03:21:01 +0100 [thread overview]
Message-ID: <20230312022101.12UZHnwAY3Dn0t8SnaJE6dDr8k4ecDdMFoPLrc1I_ws@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42687@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
New review comment by astralchan on void-packages repository
https://github.com/void-linux/void-packages/pull/42687#discussion_r1133174298
Comment:
I like evaluating expressions then substituting them. It makes it simpler for me to maintain. Specifically, if I see a substitution inside expanded in `distfiles`, I would need to mentally expand `/./_` in the middle of a URL. This visually is confusing to me, the maintainer. If I see `_version`, I can expand to see that it would expand to `r3_9_1` then substitute that. Those are the mechanisms by which it makes it more maintainable for me.
next prev parent reply other threads:[~2023-03-12 2:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 9:49 [PR PATCH] " astralchan
2023-03-10 19:54 ` [PR REVIEW] " paper42
2023-03-10 19:54 ` paper42
2023-03-11 1:20 ` astralchan
2023-03-11 1:26 ` [PR PATCH] [Updated] " astralchan
2023-03-11 1:27 ` [PR REVIEW] " astralchan
2023-03-11 6:28 ` classabbyamp
2023-03-11 8:26 ` astralchan
2023-03-11 8:27 ` astralchan
2023-03-11 8:29 ` paper42
2023-03-12 2:13 ` astralchan
2023-03-12 2:19 ` astralchan
2023-03-12 2:21 ` astralchan [this message]
2023-06-11 2:09 ` github-actions
2023-06-11 11:25 ` [PR PATCH] [Updated] " classabbyamp
2023-06-11 11:31 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230312022101.12UZHnwAY3Dn0t8SnaJE6dDr8k4ecDdMFoPLrc1I_ws@z \
--to=astralchan@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).