[PR PATCH] New package: rogue-5.4.4

[PR PATCH] New package: rogue-5.4.4

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

There is a new pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages rogue
https://github.com/void-linux/void-packages/pull/42816

New package: rogue-5.4.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc


A patch file from https://github.com/void-linux/void-packages/pull/42816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rogue-42816.patch --]
[-- Type: text/x-diff, Size: 1193 bytes --]

From 23042a6d31590f2b06c55a1cd2f812d442f02a25 Mon Sep 17 00:00:00 2001
From: sirkhancision <jsantiago12tone@gmail.com>
Date: Thu, 16 Mar 2023 02:52:49 -0300
Subject: [PATCH] New package: rogue-5.4.4

---
 srcpkgs/rogue/template | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 srcpkgs/rogue/template

diff --git a/srcpkgs/rogue/template b/srcpkgs/rogue/template
new file mode 100644
index 000000000000..91809081b04a
--- /dev/null
+++ b/srcpkgs/rogue/template
@@ -0,0 +1,27 @@
+# Template file for 'rogue'
+pkgname=rogue
+version=5.4.4
+revision=1
+makedepends=ncurses-devel
+depends="ncurses"
+short_desc="Dungeon crawl game from the 80s"
+maintainer="sirkhancision <jsantiago12tone@gmail.com>"
+license="custom:Rogue"
+homepage="http://rogue.rogueforge.net/"
+distfiles="https://github.com/phs/rogue/archive/v$version.tar.gz"
+checksum=aea2204f046576e06ba1bc53808cc193306e4a694a92a573e739289117f91a41
+
+do_build() {
+	./configure
+	make
+}
+
+do_install() {
+	vbin rogue
+	sed -i 's/rogue.png/rogue/' rogue.desktop
+	vinstall rogue.desktop 644 usr/share/applications
+	vinstall rogue.png 644 usr/share/pixmaps
+
+	vman rogue.6
+	vlicense LICENSE.TXT
+}

Re: [PR PATCH] [Updated] New package: rogue-5.4.4

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

There is an updated pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages rogue
https://github.com/void-linux/void-packages/pull/42816

New package: rogue-5.4.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc


A patch file from https://github.com/void-linux/void-packages/pull/42816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rogue-42816.patch --]
[-- Type: text/x-diff, Size: 1215 bytes --]

From 8e21b081d3048efba5631eb3fee612dad046e023 Mon Sep 17 00:00:00 2001
From: sirkhancision <jsantiago12tone@gmail.com>
Date: Thu, 16 Mar 2023 02:52:49 -0300
Subject: [PATCH] New package: rogue-5.4.4

---
 srcpkgs/rogue/template | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 srcpkgs/rogue/template

diff --git a/srcpkgs/rogue/template b/srcpkgs/rogue/template
new file mode 100644
index 000000000000..557e099ad946
--- /dev/null
+++ b/srcpkgs/rogue/template
@@ -0,0 +1,28 @@
+# Template file for 'rogue'
+pkgname=rogue
+version=5.4.4
+revision=1
+archs="x86_64-glibc
+makedepends=ncurses-devel
+depends="ncurses"
+short_desc="Dungeon crawl game from the 80s"
+maintainer="sirkhancision <jsantiago12tone@gmail.com>"
+license="custom:Rogue"
+homepage="http://rogue.rogueforge.net/"
+distfiles="https://github.com/phs/rogue/archive/v$version.tar.gz"
+checksum=aea2204f046576e06ba1bc53808cc193306e4a694a92a573e739289117f91a41
+
+do_build() {
+	./configure
+	make
+}
+
+do_install() {
+	vbin rogue
+	sed -i 's/rogue.png/rogue/' rogue.desktop
+	vinstall rogue.desktop 644 usr/share/applications
+	vinstall rogue.png 644 usr/share/pixmaps
+
+	vman rogue.6
+	vlicense LICENSE.TXT
+}

Re: [PR PATCH] [Updated] New package: rogue-5.4.4

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

There is an updated pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages rogue
https://github.com/void-linux/void-packages/pull/42816

New package: rogue-5.4.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc


A patch file from https://github.com/void-linux/void-packages/pull/42816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rogue-42816.patch --]
[-- Type: text/x-diff, Size: 1216 bytes --]

From 900b01cbe43650eec9fbb845b715f036d9b5874e Mon Sep 17 00:00:00 2001
From: sirkhancision <jsantiago12tone@gmail.com>
Date: Thu, 16 Mar 2023 02:52:49 -0300
Subject: [PATCH] New package: rogue-5.4.4

---
 srcpkgs/rogue/template | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 srcpkgs/rogue/template

diff --git a/srcpkgs/rogue/template b/srcpkgs/rogue/template
new file mode 100644
index 000000000000..3493f5df86d6
--- /dev/null
+++ b/srcpkgs/rogue/template
@@ -0,0 +1,28 @@
+# Template file for 'rogue'
+pkgname=rogue
+version=5.4.4
+revision=1
+archs="x86_64-glibc"
+makedepends=ncurses-devel
+depends="ncurses"
+short_desc="Dungeon crawl game from the 80s"
+maintainer="sirkhancision <jsantiago12tone@gmail.com>"
+license="custom:Rogue"
+homepage="http://rogue.rogueforge.net/"
+distfiles="https://github.com/phs/rogue/archive/v$version.tar.gz"
+checksum=aea2204f046576e06ba1bc53808cc193306e4a694a92a573e739289117f91a41
+
+do_build() {
+	./configure
+	make
+}
+
+do_install() {
+	vbin rogue
+	sed -i 's/rogue.png/rogue/' rogue.desktop
+	vinstall rogue.desktop 644 usr/share/applications
+	vinstall rogue.png 644 usr/share/pixmaps
+
+	vman rogue.6
+	vlicense LICENSE.TXT
+}

Re: [PR REVIEW] New package: rogue-5.4.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42816#discussion_r1139663539

Comment:
```suggestion
```
not needed with the build_style, and configure should be in do_configure() if it's explicit anyways

Re: [PR REVIEW] New package: rogue-5.4.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42816#discussion_r1139664102

Comment:
```suggestion
post_install() {
```
make the sed into a patch

Re: [PR REVIEW] New package: rogue-5.4.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42816#discussion_r1139664464

Comment:
```suggestion
```
this and the vbin are already done by the default `make install`

Re: [PR REVIEW] New package: rogue-5.4.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42816#discussion_r1139662868

Comment:
```suggestion
distfiles="https://gitlab.com/philhsmith/rogue/-/archive/v${version}/rogue-v${version}.tar.gz"
```
![image](https://user-images.githubusercontent.com/5366828/225806616-88267938-7986-41bf-aa2c-63584b87bcd0.png)

Re: [PR REVIEW] New package: rogue-5.4.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42816#discussion_r1139658296

Comment:
```suggestion
build_style=gnu-configure
configure_args="--enable-scorefile=/var/games/rogue/rogue.scr"
```
you don't need to restrict the archs, it builds just fine on all archs.

also use the build_style

Re: [PR REVIEW] New package: rogue-5.4.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42816#discussion_r1139669595

Comment:
```suggestion
```
autodetected

Re: [PR REVIEW] New package: rogue-5.4.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42816#discussion_r1139670549

Comment:
```suggestion
license="BSD-3-Clause"
```

Re: [PR PATCH] [Updated] New package: rogue-5.4.4

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

There is an updated pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages rogue
https://github.com/void-linux/void-packages/pull/42816

New package: rogue-5.4.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc


A patch file from https://github.com/void-linux/void-packages/pull/42816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rogue-42816.patch --]
[-- Type: text/x-diff, Size: 1935 bytes --]

From 3ccef8a32617338936dcbc8ad24abd4bbc694eb1 Mon Sep 17 00:00:00 2001
From: sirkhancision <jsantiago12tone@gmail.com>
Date: Thu, 16 Mar 2023 02:52:49 -0300
Subject: [PATCH] New package: rogue-5.4.4

---
 srcpkgs/rogue/patches/desktop-file.patch | 16 ++++++++++++++++
 srcpkgs/rogue/template                   | 19 +++++++++++++++++++
 2 files changed, 35 insertions(+)
 create mode 100644 srcpkgs/rogue/patches/desktop-file.patch
 create mode 100644 srcpkgs/rogue/template

diff --git a/srcpkgs/rogue/patches/desktop-file.patch b/srcpkgs/rogue/patches/desktop-file.patch
new file mode 100644
index 000000000000..f61ea5716a79
--- /dev/null
+++ b/srcpkgs/rogue/patches/desktop-file.patch
@@ -0,0 +1,16 @@
+diff --git a/rogue.desktop b/rogue.desktop
+index 74f9518..34b02f4 100644
+--- a/rogue.desktop
++++ b/rogue.desktop
+@@ -2,9 +2,9 @@
+ Encoding=UTF-8
+ Name=Rogue
+ GenericName=Rogue
+-Comment=The original curses-based adventure game
++Comment=Dungeon crawl game from the 80s
+ Exec=rogue
+-Icon=rogue.png
++Icon=rogue
+ Terminal=true
+ Type=Application
+ Categories=Game;RolePlaying;
diff --git a/srcpkgs/rogue/template b/srcpkgs/rogue/template
new file mode 100644
index 000000000000..98ad61b87990
--- /dev/null
+++ b/srcpkgs/rogue/template
@@ -0,0 +1,19 @@
+# Template file for 'rogue'
+pkgname=rogue
+version=5.4.4
+revision=1
+build_style=gnu-configure
+configure_args="--enable-scorefile=/var/games/rogue/rogue.scr"
+makedepends="ncurses-devel"
+short_desc="Dungeon crawl game from the 80s"
+maintainer="sirkhancision <jsantiago12tone@gmail.com>"
+license="BSD-3-Clause"
+homepage="http://rogue.rogueforge.net/"
+distfiles="https://gitlab.com/philhsmith/rogue/-/archive/v${version}/rogue-v${version}.tar.gz"
+checksum=df9f837817ceeededb77395ba990d83894f992ed7f534f3baab2ca4a80921b63
+
+post_install() {
+	vinstall rogue.desktop 644 usr/share/applications
+	vinstall rogue.png 644 usr/share/pixmaps
+	vlicense LICENSE.TXT
+}

Re: [PR REVIEW] New package: rogue-5.4.4

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/42816#discussion_r1139700384

Comment:
Damn, I'd tried using gnu-configure before, but for some reason it didn't build. Also, it's preferred to have save files and the likes of it under /var/games?

Re: [PR REVIEW] New package: rogue-5.4.4

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/42816#discussion_r1139701054

Comment:
Thanks for this one, had some trouble finding the license because I only really looked inside the source files.

Re: [PR REVIEW] New package: rogue-5.4.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42816#discussion_r1139708854

Comment:
I'm following the example of a few other packages:

```
$ xlocate var/games
Powermanga-0.93.1_1  /var/games/powermanga/powermanga.hi
Powermanga-0.93.1_1  /var/games/powermanga/powermanga.hi-easy
Powermanga-0.93.1_1  /var/games/powermanga/powermanga.hi-hard
bsd-games-2.17_5     /var/games/bsdgames/hack/data
bsd-games-2.17_5     /var/games/bsdgames/hack/help
bsd-games-2.17_5     /var/games/bsdgames/hack/hh
bsd-games-2.17_5     /var/games/bsdgames/hack/rumors
bsd-games-2.17_5     /var/games/bsdgames/phantasia/characs
bsd-games-2.17_5     /var/games/bsdgames/phantasia/gold
bsd-games-2.17_5     /var/games/bsdgames/phantasia/lastdead
bsd-games-2.17_5     /var/games/bsdgames/phantasia/mess
bsd-games-2.17_5     /var/games/bsdgames/phantasia/monsters
bsd-games-2.17_5     /var/games/bsdgames/phantasia/motd
bsd-games-2.17_5     /var/games/bsdgames/phantasia/scoreboard
bsd-games-2.17_5     /var/games/bsdgames/phantasia/void
lbreakout2-2.6.5_2   /var/games/lbreakout2/lbreakout2.hscr
ltris-1.2.6_1        /var/games/ltris/ltris.hscr
nethack-3.6.7_1      /var/games/nethack/nhdat
nethack-3.6.7_1      /var/games/nethack/symbols
typespeed-0.6.5_2    /var/games/typespeed.score
xlennart-1.1.1_1     /var/games/xlennart.scores.default
```

Re: [PR REVIEW] New package: rogue-5.4.4

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/42816#discussion_r1139710719

Comment:
Oh that's a nifty command, thanks!

Re: [PR PATCH] [Updated] New package: rogue-5.4.4

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 763 bytes --]

There is an updated pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages rogue
https://github.com/void-linux/void-packages/pull/42816

New package: rogue-5.4.4
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - armv7l
  - x86_64-musl
  - i686


A patch file from https://github.com/void-linux/void-packages/pull/42816.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rogue-42816.patch --]
[-- Type: text/x-diff, Size: 1892 bytes --]

From 0676225cb7d8a3feea4f4fe0ecede74d843fc62f Mon Sep 17 00:00:00 2001
From: sirkhancision <jsantiago12tone@gmail.com>
Date: Thu, 16 Mar 2023 02:52:49 -0300
Subject: [PATCH] New package: rogue-5.4.4

---
 srcpkgs/rogue/patches/desktop-icon.patch | 15 +++++++++++++++
 srcpkgs/rogue/template                   | 19 +++++++++++++++++++
 2 files changed, 34 insertions(+)
 create mode 100644 srcpkgs/rogue/patches/desktop-icon.patch
 create mode 100644 srcpkgs/rogue/template

diff --git a/srcpkgs/rogue/patches/desktop-icon.patch b/srcpkgs/rogue/patches/desktop-icon.patch
new file mode 100644
index 000000000000..7bb78c25c98a
--- /dev/null
+++ b/srcpkgs/rogue/patches/desktop-icon.patch
@@ -0,0 +1,15 @@
+diff --git a/rogue.desktop b/rogue.desktop
+index 74f9518..34b02f4 100644
+--- a/rogue.desktop
++++ b/rogue.desktop
+@@ -2,9 +2,9 @@
+ Encoding=UTF-8
+ Name=Rogue
+ GenericName=Rogue
+ Comment=The original curses-based adventure game
+ Exec=rogue
+-Icon=rogue.png
++Icon=rogue
+ Terminal=true
+ Type=Application
+ Categories=Game;RolePlaying;
diff --git a/srcpkgs/rogue/template b/srcpkgs/rogue/template
new file mode 100644
index 000000000000..98ad61b87990
--- /dev/null
+++ b/srcpkgs/rogue/template
@@ -0,0 +1,19 @@
+# Template file for 'rogue'
+pkgname=rogue
+version=5.4.4
+revision=1
+build_style=gnu-configure
+configure_args="--enable-scorefile=/var/games/rogue/rogue.scr"
+makedepends="ncurses-devel"
+short_desc="Dungeon crawl game from the 80s"
+maintainer="sirkhancision <jsantiago12tone@gmail.com>"
+license="BSD-3-Clause"
+homepage="http://rogue.rogueforge.net/"
+distfiles="https://gitlab.com/philhsmith/rogue/-/archive/v${version}/rogue-v${version}.tar.gz"
+checksum=df9f837817ceeededb77395ba990d83894f992ed7f534f3baab2ca4a80921b63
+
+post_install() {
+	vinstall rogue.desktop 644 usr/share/applications
+	vinstall rogue.png 644 usr/share/pixmaps
+	vlicense LICENSE.TXT
+}

Re: [PR PATCH] [Merged]: New package: rogue-5.4.4

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 597 bytes --]

There's a merged pull request on the void-packages repository

New package: rogue-5.4.4
https://github.com/void-linux/void-packages/pull/42816

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - armv7l
  - x86_64-musl
  - i686