From: 0x5c <0x5c@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: riff: update to 2.23.1.
Date: Sun, 19 Mar 2023 22:20:28 +0100 [thread overview]
Message-ID: <20230319212028.aXFszCG9Na5o-c7vmDdgnjlpfpfzb3bRhzLKYmnc6yE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42868@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 448 bytes --]
New comment by 0x5c on void-packages repository
https://github.com/void-linux/void-packages/pull/42868#issuecomment-1475403065
Comment:
Void-packages is not a good test case for these bugs. Git diff seems to always use the exact string `\ No newline at end of file` regardless of the locale (unlike `diff -u`), hiding the first bug. Then since the repo doesn't contain many files that lack a newline at the end, it's easy to miss the second bug.
next prev parent reply other threads:[~2023-03-19 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 19:14 [PR PATCH] " icp1994
2023-03-19 19:26 ` 0x5c
2023-03-19 19:35 ` icp1994
2023-03-19 21:20 ` 0x5c [this message]
2023-03-22 4:08 ` [PR PATCH] [Closed]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230319212028.aXFszCG9Na5o-c7vmDdgnjlpfpfzb3bRhzLKYmnc6yE@z \
--to=0x5c@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).