Re: [PR PATCH] [Updated] open-iscsi: add runit service [ci skip]

[thetredev <thetredev@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

There is an updated pull request by thetredev against master on the void-packages repository

https://github.com/thetredev/void-packages open-iscsi/add-runit-service
https://github.com/void-linux/void-packages/pull/42864

open-iscsi: add runit service [ci skip]
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, `x86_64-glibc`

#### Notes
- This fixes issue #40861 

A patch file from https://github.com/void-linux/void-packages/pull/42864.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-open-iscsi/add-runit-service-42864.patch --]
[-- Type: text/x-diff, Size: 2175 bytes --]

From 6d8fe18be333065488a7a165144828ed6980cc05 Mon Sep 17 00:00:00 2001
From: Timo Reichl <thetredev@gmail.com>
Date: Sun, 19 Mar 2023 17:40:05 +0100
Subject: [PATCH] open-iscsi: Add runit service

Signed-off-by: Timo Reichl <thetredev@gmail.com>
---
 srcpkgs/open-iscsi/files/iscsid/run | 4 ++++
 srcpkgs/open-iscsi/template         | 7 ++++++-
 2 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100755 srcpkgs/open-iscsi/files/iscsid/run

diff --git a/srcpkgs/open-iscsi/files/iscsid/run b/srcpkgs/open-iscsi/files/iscsid/run
new file mode 100755
index 000000000000..d78c31b747dd
--- /dev/null
+++ b/srcpkgs/open-iscsi/files/iscsid/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+exec 2>&1
+[ -r conf ] && . ./conf
+exec iscsid -f
diff --git a/srcpkgs/open-iscsi/template b/srcpkgs/open-iscsi/template
index a146dae7a7b2..5044dd5db96c 100644
--- a/srcpkgs/open-iscsi/template
+++ b/srcpkgs/open-iscsi/template
@@ -1,7 +1,7 @@
 # Template file for 'open-iscsi'
 pkgname=open-iscsi
 version=2.1.8
-revision=1
+revision=2
 conf_files="/etc/iscsi/iscsid.conf /etc/iscsi/initiatorname.iscsi"
 build_style=gnu-configure
 hostmakedepends="automake libtool pkg-config"
@@ -16,22 +16,27 @@ checksum=9565bdf6b68b223e1e0d455d9a04d7536724a3f5b5a254e9398d06b2a0c6b6d2
 case "$XBPS_TARGET_MACHINE" in
 	*-musl) CFLAGS+=" -D_LINUX_IF_ETHER_H -Wno-error=format -Wno-error=cpp";;
 esac
+
 post_extract() {
 	vsed -i -e '/CC.*-o/s/$/ $(LDFLAGS)/' utils/Makefile usr/Makefile
 	vsed -i -e 's/lib64/lib/g' libopeniscsiusr/Makefile
 	vsed -i -e 's,<linux/if_ether.h>,<netinet/if_ether.h>,g' usr/iscsi_net_util.c
 	vsed -i -e '1i#include <netinet/if_ether.h>' iscsiuio/src/unix/libs/bnx2x.c libopeniscsiusr/misc.c
 }
+
 do_configure() {
 	( cd iscsiuio && autoreconf -fi && ./configure ${configure_args} CFLAGS="-DNO_SYSTEMD" )
 }
+
 do_build() {
 	make ${makejobs} CC="$CC" \
 		OPTFLAGS="$CFLAGS $(pkg-config --cflags libkmod) -pthread -DNO_SYSTEMD" \
 		LDFLAGS="$LDFLAGS $(pkg-config --libs libkmod) -pthread" NO_SYSTEMD=1
 }
+
 do_install() {
 	make install exec_prefix=/usr SBINDIR=/usr/bin RULESDIR=/usr/lib/udev/rules.d DESTDIR="$DESTDIR"
+	vsv iscsid
 
 	rm -rf ${DESTDIR}/usr/lib/systemd