From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: imv: configure with -Db_ndebug=false
Date: Mon, 20 Mar 2023 05:08:00 +0100 [thread overview]
Message-ID: <20230320040800.aga8ZNvsTK4w-_YQEX45Q8UeFz1thpbbMGjSIMk70vA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42865@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
There's a merged pull request on the void-packages repository
imv: configure with -Db_ndebug=false
https://github.com/void-linux/void-packages/pull/42865
Description:
`WAYLAND_DISPLAY= imv-wayland` and `DISPLAY= imv-x11` segfault because assertions are used to check for errors in these cases and we build with `-Db_ndebug=true` by default.
By looking at the commit history, I see that similar problems occurred in the past for other meson projects.
Meson, unlike cmake, doesn't define NDEBUG by default for release build types, so it's possible that many meson projects rely on assertions being always enabled. I don't believe it's safe to have `-Db_ndebug=true` in our build style.
#### Testing the changes
- I tested the changes in this PR: **YES**
prev parent reply other threads:[~2023-03-20 4:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 19:01 [PR PATCH] " r-ricci
2023-03-19 19:23 ` mhmdanas
2023-03-19 19:23 ` mhmdanas
2023-03-20 4:08 ` classabbyamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320040800.aga8ZNvsTK4w-_YQEX45Q8UeFz1thpbbMGjSIMk70vA@z \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).