Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] eggdrop: Remove useless vsed
@ 2023-03-18 14:17 gmbeard
  2023-03-20  4:31 ` [PR PATCH] [Merged]: " classabbyamp
  0 siblings, 1 reply; 2+ messages in thread
From: gmbeard @ 2023-03-18 14:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

There is a new pull request by gmbeard against master on the void-packages repository

https://github.com/gmbeard/void-packages fix/eggdrop-useless-vsed
https://github.com/void-linux/void-packages/pull/42837

eggdrop: Remove useless vsed
<!-- Uncomment relevant sections and delete options which are not applicable -->

Addresses part of tracking issue #42441
- [x] eggdrop

#### Testing the changes
- I tested the changes in this PR: **briefly**

Running the binary both before and after this change gives the following error:

    $ eggdrop
    LANG: No lang files found for section core.

    Eggdrop v1.9.4 (C) 1997 Robey Pointer (C) 2010-2022 Eggheads
    --- Loading eggdrop v1.9.4 (Sat Mar 18 2023)
    * MSG534

I don't use *eggdrop* so I'm not sure how to test this further. Happy to take advice on this and retest if needed.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86\_64-glibc


A patch file from https://github.com/void-linux/void-packages/pull/42837.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/eggdrop-useless-vsed-42837.patch --]
[-- Type: text/x-diff, Size: 773 bytes --]

From fe269eec35f293ce3dc9ad3247a445a4b997937a Mon Sep 17 00:00:00 2001
From: Greg Beard <gmbeard@googlemail.com>
Date: Sat, 18 Mar 2023 14:01:27 +0000
Subject: [PATCH] eggdrop: Remove useless vsed

`vsed` for `language/` in `eggdrop.conf` doesn't modify anything
---
 srcpkgs/eggdrop/template | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/srcpkgs/eggdrop/template b/srcpkgs/eggdrop/template
index 4e356ec0add2..f5f5a504030f 100644
--- a/srcpkgs/eggdrop/template
+++ b/srcpkgs/eggdrop/template
@@ -33,6 +33,9 @@ do_install() {
 	for _asset in language scripts help; do
 		vmkdir "${_share}/${_asset}/"
 		vcopy "ed_staging/${_asset}/*" "${_share}/${_asset}"
+	done
+
+	for _asset in scripts help; do
 		vsed -e "s|${_asset}/|/${_share}/&|" -i eggdrop.conf
 	done
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: eggdrop: Remove useless vsed
  2023-03-18 14:17 [PR PATCH] eggdrop: Remove useless vsed gmbeard
@ 2023-03-20  4:31 ` classabbyamp
  0 siblings, 0 replies; 2+ messages in thread
From: classabbyamp @ 2023-03-20  4:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1409 bytes --]

There's a merged pull request on the void-packages repository

eggdrop: Remove useless vsed
https://github.com/void-linux/void-packages/pull/42837

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

Addresses part of tracking issue #42441
- [x] eggdrop

#### Testing the changes
- I tested the changes in this PR: **briefly**

Running the binary both before and after this change gives the following error:

    $ eggdrop
    LANG: No lang files found for section core.

    Eggdrop v1.9.4 (C) 1997 Robey Pointer (C) 2010-2022 Eggheads
    --- Loading eggdrop v1.9.4 (Sat Mar 18 2023)
    * MSG534

I don't use *eggdrop* so I'm not sure how to test this further. Happy to take advice on this and retest if needed.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86\_64-glibc


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-20  4:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-18 14:17 [PR PATCH] eggdrop: Remove useless vsed gmbeard
2023-03-20  4:31 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).