Github messages for voidlinux
 help / color / mirror / Atom feed
From: DiegoMagdaleno <DiegoMagdaleno@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] new package: moar
Date: Sat, 01 Apr 2023 02:41:03 +0200	[thread overview]
Message-ID: <20230401004103.LZx4FokZpuMMQitEDH-FAXPuFghIUf9CSkjnchqlSTo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43142@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

There is an updated pull request by DiegoMagdaleno against master on the void-packages repository

https://github.com/DiegoMagdaleno/void-packages master
https://github.com/void-linux/void-packages/pull/43142

new package: moar
Uncomment relevant sections and delete options which are not applicable

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc )

A patch file from https://github.com/void-linux/void-packages/pull/43142.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-43142.patch --]
[-- Type: text/x-diff, Size: 2952 bytes --]

From 6c6b66c8aa5df01a9a1c1a9af21478d060dbffe4 Mon Sep 17 00:00:00 2001
From: Diego Magdaleno <38844659+DiegoMagdaleno@users.noreply.github.com>
Date: Fri, 31 Mar 2023 08:40:06 -0600
Subject: [PATCH 1/3] Add moar package

---
 srcpkgs/moar/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/moar/template

diff --git a/srcpkgs/moar/template b/srcpkgs/moar/template
new file mode 100644
index 000000000000..cec35536519e
--- /dev/null
+++ b/srcpkgs/moar/template
@@ -0,0 +1,14 @@
+# Template file for 'moar'
+pkgname=moar
+version=1.13.0
+revision=0
+build_style=go
+go_import_path=github.com/walles/moar
+hostmakedepends="git"
+short_desc="Drop-in replacement for the less pager"
+maintainer="Diego Magdaleno <diegomagdaleno@pm.me>"
+license="BSD"
+homepage="https://github.com/walles/moar"
+changelog="https://github.com/waller/moar/releases"
+distfiles="https://github.com/walles/moar/archive/refs/tags/v${version}.tar.gz"
+checksum=65eac0d4f8a40f0198a93f0888a60a28e8466b2ee9d0437f143db5c25d5e9319

From 95b007d4bed81b0e4e879f0c0a7dae48497d751f Mon Sep 17 00:00:00 2001
From: Diego Magdaleno <38844659+DiegoMagdaleno@users.noreply.github.com>
Date: Fri, 31 Mar 2023 08:55:32 -0600
Subject: [PATCH 2/3] Install man pages

---
 srcpkgs/moar/template | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/srcpkgs/moar/template b/srcpkgs/moar/template
index cec35536519e..5e7f5932e701 100644
--- a/srcpkgs/moar/template
+++ b/srcpkgs/moar/template
@@ -12,3 +12,7 @@ homepage="https://github.com/walles/moar"
 changelog="https://github.com/waller/moar/releases"
 distfiles="https://github.com/walles/moar/archive/refs/tags/v${version}.tar.gz"
 checksum=65eac0d4f8a40f0198a93f0888a60a28e8466b2ee9d0437f143db5c25d5e9319
+
+post_install() {
+  vman moar.1
+}

From 93045e80fd495bffad57eac4385ec65388a80ecb Mon Sep 17 00:00:00 2001
From: Diego Magdaleno <diegomagdaleno@protonmail.com>
Date: Fri, 31 Mar 2023 18:39:24 -0600
Subject: [PATCH 3/3] [Fix] Apply the suggested fixes

---
 srcpkgs/moar/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/moar/template b/srcpkgs/moar/template
index 5e7f5932e701..03921fee8908 100644
--- a/srcpkgs/moar/template
+++ b/srcpkgs/moar/template
@@ -1,13 +1,13 @@
 # Template file for 'moar'
 pkgname=moar
 version=1.13.0
-revision=0
+revision=1
 build_style=go
 go_import_path=github.com/walles/moar
-hostmakedepends="git"
+go_ldflags="-X main.versionString=${version}"
 short_desc="Drop-in replacement for the less pager"
 maintainer="Diego Magdaleno <diegomagdaleno@pm.me>"
-license="BSD"
+license="BSD-2-Clause"
 homepage="https://github.com/walles/moar"
 changelog="https://github.com/waller/moar/releases"
 distfiles="https://github.com/walles/moar/archive/refs/tags/v${version}.tar.gz"
@@ -15,4 +15,5 @@ checksum=65eac0d4f8a40f0198a93f0888a60a28e8466b2ee9d0437f143db5c25d5e9319
 
 post_install() {
   vman moar.1
+  vlicense LICENSE
 }

  parent reply	other threads:[~2023-04-01  0:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31 15:00 [PR PATCH] " DiegoMagdaleno
2023-03-31 15:06 ` abenson
2023-03-31 15:06 ` [PR REVIEW] " abenson
2023-03-31 15:06 ` paper42
2023-03-31 15:08 ` abenson
2023-03-31 15:08 ` abenson
2023-03-31 15:12 ` abenson
2023-04-01  0:41 ` DiegoMagdaleno [this message]
2023-04-01  0:42 ` [PR PATCH] [Updated] " DiegoMagdaleno
2023-04-01  0:43 ` DiegoMagdaleno
2023-04-02  7:43 ` atweiden
2023-04-05 14:32 ` DiegoMagdaleno
2023-04-05 23:35 ` atweiden
2023-04-06 15:36 ` [PR PATCH] [Updated] " DiegoMagdaleno
2023-04-06 15:37 ` DiegoMagdaleno
2023-04-06 15:40 ` DiegoMagdaleno
2023-04-06 17:38 ` DiegoMagdaleno
2023-06-25 18:49 ` [PR PATCH] [Merged]: " Duncaen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230401004103.LZx4FokZpuMMQitEDH-FAXPuFghIUf9CSkjnchqlSTo@z \
    --to=diegomagdaleno@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).