From: icp1994 <icp1994@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: RFC: common/build-style/cargo.sh: use --locked for build and check as well
Date: Mon, 03 Apr 2023 17:54:02 +0200 [thread overview]
Message-ID: <20230403155402.deWb_q5gRJpr3bG1wo1J67Q3oQyYZ_IxFNVbz44py14@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43233@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
New comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/43233#issuecomment-1494576152
Comment:
Another tangent: is it worth adding a `make_build_args` to the command under `do_build()`? There's been at least a few times where I wanted to add `--package <spec>` for cargo build but putting it in `configure_args` breaks `do_install` since cargo install doesn't accept that option.
next prev parent reply other threads:[~2023-04-03 15:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 6:50 [PR PATCH] " jcgruenhage
2023-04-03 6:59 ` [PR PATCH] [Updated] RFC: " jcgruenhage
2023-04-03 9:00 ` stefankreutz
2023-04-03 9:57 ` jcgruenhage
2023-04-03 15:54 ` icp1994 [this message]
2023-04-03 18:44 ` jcgruenhage
2023-04-03 19:12 ` icp1994
2023-04-04 1:21 ` classabbyamp
2023-04-04 8:43 ` jcgruenhage
2023-04-04 8:44 ` jcgruenhage
2023-04-08 18:11 ` [PR PATCH] [Updated] " jcgruenhage
2023-04-08 18:29 ` jcgruenhage
2023-04-08 18:31 ` jcgruenhage
2023-04-13 5:01 ` classabbyamp
2023-04-13 5:59 ` jcgruenhage
2023-04-13 13:24 ` classabbyamp
2023-04-13 14:21 ` [PR PATCH] [Updated] " jcgruenhage
2023-04-13 14:22 ` jcgruenhage
2023-04-13 14:27 ` jcgruenhage
2023-04-13 14:44 ` jcgruenhage
2023-04-13 14:44 ` [PR PATCH] [Updated] " jcgruenhage
2023-04-13 15:52 ` jcgruenhage
2023-04-13 17:15 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403155402.deWb_q5gRJpr3bG1wo1J67Q3oQyYZ_IxFNVbz44py14@z \
--to=icp1994@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).