From: ElementW <ElementW@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] sane: fix PDF-producing eSCL scanners failing with `Invalid argument`
Date: Fri, 07 Apr 2023 17:08:39 +0200 [thread overview]
Message-ID: <20230407150839.xxZTc-2zTW84M1SyzQPlbQzgOeGOpnkc9aja_A0LDNk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42569@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
There is an updated pull request by ElementW against master on the void-packages repository
https://github.com/ElementW/void-packages sane-fix-pdf-ecsl-scanners
https://github.com/void-linux/void-packages/pull/42569
sane: fix PDF-producing eSCL scanners failing with `Invalid argument`
eSCL-speaking scanners that produce PDF-formatted output scan properly, but completion is only met with `sane_start: Invalid argument` expressed in various forms depending on front-end.
This is due to SANE being built without PDF support, provided by poppler-glib; this commit enables that as a default-on option, fixing support for those scanners.
#### Testing the changes
- I tested the changes in this PR: **YES** (using an EPSON XP-325)
A patch file from https://github.com/void-linux/void-packages/pull/42569.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sane-fix-pdf-ecsl-scanners-42569.patch --]
[-- Type: text/x-diff, Size: 2075 bytes --]
From 59cafa7d2f05437a464553f5d1bb20a01708f1b6 Mon Sep 17 00:00:00 2001
From: Celeste Wouters <perso@elementw.net>
Date: Fri, 3 Mar 2023 18:46:32 +0100
Subject: [PATCH] sane: fix PDF-producing eSCL scanners failing with `Invalid
argument`
eSCL-speaking scanners that produce PDF-formatted output scan properly,
but completion is only met with `sane_start: Invalid argument` expressed
in various forms depending on front-end.
This is due to SANE being built without PDF support, provided by
poppler-glib; this commit enables that as a default-on option, fixing
support for those scanners.
---
srcpkgs/sane/template | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/sane/template b/srcpkgs/sane/template
index 2a40d0ad5813..74e6bdda7b44 100644
--- a/srcpkgs/sane/template
+++ b/srcpkgs/sane/template
@@ -2,15 +2,16 @@
pkgname=sane
_gitlab_release_hash=7d30fab4e115029d91027b6a58d64b43
version=1.1.1
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--disable-locking --enable-ipv6 --enable-pthread
--with-usb --docdir=/usr/share/doc/sane ac_cv_func_mmap_fixed_mapped=yes
- $(vopt_with snmp)"
+ $(vopt_with snmp) $(vopt_with poppler poppler-glib)"
hostmakedepends="pkg-config python3"
makedepends="libjpeg-turbo-devel tiff-devel libgphoto2-devel v4l-utils-devel
libusb-devel openssl-devel libxml2-devel $(vopt_if snmp net-snmp-devel)
- $(vopt_if avahi 'avahi-libs-devel libcurl-devel')"
+ $(vopt_if avahi 'avahi-libs-devel libcurl-devel')
+ $(vopt_if poppler 'cairo-devel poppler-glib-devel')"
depends="$(vopt_if snmp net-snmp)"
conf_files="/etc/sane.d/*.conf"
short_desc="Scanner Access Now Easy"
@@ -26,8 +27,8 @@ noshlibprovides="avoid false detection of device drivers"
system_accounts="_saned"
_saned_groups="lp,scanner"
-build_options="avahi snmp"
-build_options_default="avahi"
+build_options="avahi snmp poppler"
+build_options_default="avahi poppler"
if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
make_check=no # tests broken on 32bit. https://gitlab.com/sane-project/backends/-/issues/157
next prev parent reply other threads:[~2023-04-07 15:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 17:50 [PR PATCH] " ElementW
2023-04-07 15:08 ` ElementW [this message]
2023-04-13 6:08 ` riddicc
2023-04-19 10:31 ` riddicc
2023-07-19 2:16 ` github-actions
2023-07-19 3:20 ` riddicc
2023-07-19 17:37 ` [PR PATCH] [Updated] " ElementW
2023-07-19 17:40 ` ElementW
2023-07-30 11:25 ` riddicc
2023-08-05 8:18 ` [PR PATCH] [Updated] " ElementW
2023-08-05 8:19 ` ElementW
2023-11-04 1:45 ` github-actions
2023-11-04 6:10 ` riddicc
2023-11-07 15:20 ` ElementW
2024-02-06 1:44 ` github-actions
2024-02-06 9:20 ` ElementW
2024-02-06 9:55 ` riddicc
2024-05-07 1:46 ` github-actions
2024-05-07 4:14 ` riddicc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230407150839.xxZTc-2zTW84M1SyzQPlbQzgOeGOpnkc9aja_A0LDNk@z \
--to=elementw@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).