From: cattyhouse <cattyhouse@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] openssh: fix default path
Date: Sat, 08 Apr 2023 18:47:59 +0200 [thread overview]
Message-ID: <20230408164759.YKQjC4i_q2YuMygbP3aFz9jeftp2RBNEZ15hAjf4swQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43338@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
There is an updated pull request by cattyhouse against master on the void-packages repository
https://github.com/cattyhouse/void-packages patch-1
https://github.com/void-linux/void-packages/pull/43338
openssh: fix default path
set default path to '/usr/local/sbin:/usr/local/bin:/usr/bin'.
by default, openssh's default path is `/usr/bin:/bin:/usr/sbin:/sbin`, according to `appendpath` function in `/etc/profile`, /usr/local/{bin,sbin} will be append to the end of user's $PATH when it is a **ssh connection**. This fixes the issue.
[ref1 : archlinux](https://github.com/archlinux/svntogit-packages/blob/0a37d1bd869f9f1e4e6f9d6f5b249510f84140f0/trunk/PKGBUILD#L79)
[ref2 : alpine linux](https://git.alpinelinux.org/aports/tree/main/openssh/APKBUILD#n116)
@leahneukirchen @classabbyamp
A patch file from https://github.com/void-linux/void-packages/pull/43338.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-43338.patch --]
[-- Type: text/x-diff, Size: 2389 bytes --]
From dd3f285f3c07a2c716764fab2c1ca994b39c0827 Mon Sep 17 00:00:00 2001
From: Justin <cattyhouse@users.noreply.github.com>
Date: Sat, 8 Apr 2023 11:36:28 +0800
Subject: [PATCH 1/2] openssh: fix default path
set default path to '/usr/local/sbin:/usr/local/bin:/usr/bin'.
by default, openssh's default path is '/usr/bin:/bin:/usr/sbin:/sbin', according to appendpath function in /etc/profile, /usr/local/{bin,sbin} will be append to the end of $PATH when it is a ssh connection. this fixes the issue.
---
srcpkgs/openssh/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/openssh/template b/srcpkgs/openssh/template
index 88f39d31fbb3..b2c5926e7f66 100644
--- a/srcpkgs/openssh/template
+++ b/srcpkgs/openssh/template
@@ -1,7 +1,7 @@
# Template file for 'openssh'
pkgname=openssh
version=9.3p1
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--datadir=/usr/share/openssh
--sysconfdir=/etc/ssh --without-selinux --with-privsep-user=nobody
@@ -9,6 +9,7 @@ configure_args="--datadir=/usr/share/openssh
--disable-strip --with-privsep-path=/var/chroot/ssh
--with-pid-dir=/run --with-pam
--with-libedit --with-Werror
+ --with-default-path='/usr/local/sbin:/usr/local/bin:/usr/bin'
$(vopt_if ldns --with-ldns=$XBPS_CROSS_BASE/usr)
$(vopt_if ssl --with-ssl-engine --without-openssl)
$(vopt_if gssapi --with-kerberos5=$XBPS_CROSS_BASE/usr --without-kerberos5)
From bf312ad2d1f14d87f025225d287bc3c998bb1098 Mon Sep 17 00:00:00 2001
From: Justin <cattyhouse@users.noreply.github.com>
Date: Sun, 9 Apr 2023 00:47:55 +0800
Subject: [PATCH 2/2] remove single quote, it may confuse openssh
---
srcpkgs/openssh/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/openssh/template b/srcpkgs/openssh/template
index b2c5926e7f66..86d3d1759e5d 100644
--- a/srcpkgs/openssh/template
+++ b/srcpkgs/openssh/template
@@ -9,7 +9,7 @@ configure_args="--datadir=/usr/share/openssh
--disable-strip --with-privsep-path=/var/chroot/ssh
--with-pid-dir=/run --with-pam
--with-libedit --with-Werror
- --with-default-path='/usr/local/sbin:/usr/local/bin:/usr/bin'
+ --with-default-path=/usr/local/sbin:/usr/local/bin:/usr/bin
$(vopt_if ldns --with-ldns=$XBPS_CROSS_BASE/usr)
$(vopt_if ssl --with-ssl-engine --without-openssl)
$(vopt_if gssapi --with-kerberos5=$XBPS_CROSS_BASE/usr --without-kerberos5)
next prev parent reply other threads:[~2023-04-08 16:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 3:42 [PR PATCH] " cattyhouse
2023-04-08 16:29 ` cattyhouse
2023-04-08 16:47 ` cattyhouse [this message]
2023-04-08 17:02 ` cattyhouse
2023-04-10 2:24 ` abenson
2023-04-10 2:49 ` cattyhouse
2023-04-10 2:55 ` abenson
2023-04-10 3:04 ` cattyhouse
2023-04-27 12:57 ` [PR PATCH] [Closed]: " cattyhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230408164759.YKQjC4i_q2YuMygbP3aFz9jeftp2RBNEZ15hAjf4swQ@z \
--to=cattyhouse@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).