[ISSUE] Discord should use system-wide electron

[ISSUE] Discord should use system-wide electron

[JuniorSuperTux]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

New issue by JuniorSuperTux on void-packages repository

https://github.com/void-linux/void-packages/issues/43280

Description:
There seems to be an arch package patching the bundled electron and using the system-wide one: https://aur.archlinux.org/packages/discord_arch_electron

It seems like as of right now Discord does not respect ``~/.config/electron-flags.conf``, which could possibly be resolved by using system installation of electron. Moreover, this can avoid duplicating electron binaries across different electron applications. Other electron applications should also use system-wide ones.

Re: Discord should use system-wide electron

[0x5c]

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

New comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/issues/43280#issuecomment-1496910438

Comment:
> It seems like as of right now Discord does not respect ~/.config/electron-flags.conf

Are you using the latest version of the discord package? It has electron 22 which would be able to read the file. Also maybe try renaming it to `electron22-flags.conf`, it appears that some builds only look for the file matching their version.

Replacing the electron they ship might not be viable, since discord maintains a [set of patches](https://github.com/electron/electron/compare/22-x-y...discord:electron:22-x-y) on top of plain electron.
Those patches also don't seem to contain anything that would disable the conf file.

Re: Discord should use system-wide electron

[JuniorSuperTux]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

New comment by JuniorSuperTux on void-packages repository

https://github.com/void-linux/void-packages/issues/43280#issuecomment-1497013226

Comment:
Yes, I'm currently using the latest version of the Discord package. Creating ``electron22-flags.conf`` does not seem to make a difference from my current testings. It seems like that opening Discord spawns a XWayland process, which from my understanding is an emulation of Xorg. Killing the process kills the Discord instance.  The Discord process does not seem to have the arguments either. Or could it be possible that it's normal behavior?

Re: Discord should use system-wide electron

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/issues/43280#issuecomment-1497107162

Comment:
xwayland is not an emulation of xorg, it's an x server that runs within wayland

Re: Discord should use system-wide electron

[JuniorSuperTux]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

New comment by JuniorSuperTux on void-packages repository

https://github.com/void-linux/void-packages/issues/43280#issuecomment-1497395818

Comment:
> xwayland is not an emulation of xorg, it's an x server that runs within wayland

Does that imply it's totally normal? But other apps running under native wayland does not get terminated

Re: Discord should use system-wide electron

[JuniorSuperTux]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

New comment by JuniorSuperTux on void-packages repository

https://github.com/void-linux/void-packages/issues/43280#issuecomment-1497395818

Comment:
> xwayland is not an emulation of xorg, it's an x server that runs within wayland

Does that imply it's totally normal? But other apps running under native wayland does not get terminated and does not depend on the process

Re: Discord should use system-wide electron

[0x5c]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/issues/43280#issuecomment-1498455272

Comment:
Reports online about discord updating to electron22 suggest that it should work with native wayland out of the box

Re: Discord should use system-wide electron

[JuniorSuperTux]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by JuniorSuperTux on void-packages repository

https://github.com/void-linux/void-packages/issues/43280#issuecomment-1498945185

Comment:
Could it possibly be more of a Discord issue?

Re: Discord should use system-wide electron

[JuniorSuperTux]

[-- Attachment #1: Type: text/plain, Size: 2366 bytes --]

New comment by JuniorSuperTux on void-packages repository

https://github.com/void-linux/void-packages/issues/43280#issuecomment-1501138593

Comment:
I have some updates. I tried disabling XWayland in sway and then launching Discord with the essential arguments, and this is the output I got:
```
> Discord --enable-features=UseOzonePlatform --ozone-platform=wayland --enable-features=WaylandWindowDecorations --gtk-version=4

Discord 0.0.26

[3002:0409/220650.597200:ERROR:object_proxy.cc(623)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/portal/desktop: org.freedesktop.DBus.Error.InvalidArgs: No such interface “org.freedesktop.portal.FileChooser”
[3002:0409/220650.597267:ERROR:select_file_dialog_linux_portal.cc(274)] Failed to read portal version property
Starting app.
Starting updater.
2023-04-09T14:06:51.496Z [Modules] Modules initializing
2023-04-09T14:06:51.586Z [Modules] Distribution: remote
2023-04-09T14:06:51.587Z [Modules] Host updates: enabled
2023-04-09T14:06:51.587Z [Modules] Module updates: enabled
2023-04-09T14:06:51.608Z [Modules] Module install path: /home/supertux/.config/discord/0.0.26/modules
2023-04-09T14:06:51.609Z [Modules] Module installed file path: /home/supertux/.config/discord/0.0.26/modules/installed.json
2023-04-09T14:06:51.610Z [Modules] Module download path: /home/supertux/.config/discord/0.0.26/modules/pending
[3077:0409/220652.119162:ERROR:gpu_init.cc(523)] Passthrough is not supported, GL is egl, ANGLE is 
2023-04-09T14:06:57.874Z [Modules] No updates to install
2023-04-09T14:06:57.876Z [Modules] Checking for host updates.
2023-04-09T14:06:58.533Z [Modules] Host is up to date.
2023-04-09T14:06:58.534Z [Modules] Checking for module updates at https://discord.com/api/modules/stable/versions.json
2023-04-09T14:06:58.636Z [Modules] No module updates available.
Optional module ./ElectronTestRpc was not included.
[3002:0409/220659.218228:ERROR:browser_main_loop.cc(271)] Gtk: gtk_widget_get_scale_factor: assertion 'GTK_IS_WIDGET (widget)' failed
[WebContents] crashed (reason: crashed, exitCode: 11)... reloading
Optional module ./ElectronTestRpc was not included.
[WebContents] double crashed (reason: crashed, exitCode: 11)... RIP =(
```

The updater opens, but the main window crashes alongside with the updater after a while.

Re: Discord should use system-wide electron

[JuniorSuperTux]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by JuniorSuperTux on void-packages repository

https://github.com/void-linux/void-packages/issues/43280#issuecomment-1498945185

Comment:
Could it possibly be more of a Discord issue?

Re: Discord should use system-wide electron

[JuniorSuperTux]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

New comment by JuniorSuperTux on void-packages repository

https://github.com/void-linux/void-packages/issues/43280#issuecomment-1501881874

Comment:
Forgot to mention that Discord wouldn't even launch without specifying those options. I also tried launching vscode today (electron 19 system-wide), and it seems like that it also doesn't respect ``electron19-flags.conf`` which is linked to ``electron-flags.conf``. In spite of that, unlike Discord, vscode launches normally with those options explicitly passed. 

Re: Discord does not respect electron-flags.conf

[paper42]

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/issues/43280#issuecomment-1501969019

Comment:
because we don't build discord from source (they don't provide source) and only repackage a pre-built archive, we can't do anything with that

Re: Discord does not respect electron-flags.conf

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/issues/43280#issuecomment-1502709736

Comment:
I think this is out of scope for void:
- to use system electron, we'd have to add discord's patches (not going to happen for the regular `electronN` package)
![image](https://user-images.githubusercontent.com/5366828/231064844-9d51b279-d57f-40ca-8494-7321a0c8eb7d.png)
- it's otherwise proprietary, as paper mentioned, and thus we can't really solve a bug with discord's electron

Re: [ISSUE] [CLOSED] Discord does not respect electron-flags.conf

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

Closed issue by JuniorSuperTux on void-packages repository

https://github.com/void-linux/void-packages/issues/43280

Description:
There seems to be an arch package patching the bundled electron and using the system-wide one: https://aur.archlinux.org/packages/discord_arch_electron

It seems like as of right now Discord does not respect ``~/.config/electron-flags.conf``, which could possibly be resolved by using system installation of electron. Moreover, this can avoid duplicating electron binaries across different electron applications. Other electron applications should also use system-wide ones.