Github messages for voidlinux
 help / color / mirror / Atom feed
From: adigitoleo <adigitoleo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: wraith-master-1.2.1
Date: Tue, 11 Apr 2023 13:51:19 +0200	[thread overview]
Message-ID: <20230411115119.XOONgYrXjaksDDgvAc_oSBOozqkfhxwcfAwgSSELjD0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43317@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 750 bytes --]

New comment by adigitoleo on void-packages repository

https://github.com/void-linux/void-packages/pull/43317#issuecomment-1502971697

Comment:
Thanks for the review, @paper42. I've addressed the comments in the latest changes. I can repro the build failure now, but only when using xpbs-src and not when manually setting env vars and using make from the source tree. I've reached out to upstream to see if they can help, but will continue to try my best to fix it.

EDIT: Got it to work with a newer openjdk. However, since this app basically requires an entire java environment to build, and all it does is control RGB for a single type of cooler fan, it might not be a great fit for the void repos. I leave this decision up to void maintainers.

  parent reply	other threads:[~2023-04-11 11:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-07 10:29 [PR PATCH] " adigitoleo
2023-04-07 11:29 ` [PR PATCH] [Updated] " adigitoleo
2023-04-07 11:40 ` adigitoleo
2023-04-07 11:53 ` adigitoleo
2023-04-07 11:56 ` asiekierka
2023-04-07 12:10 ` adigitoleo
2023-04-07 13:02 ` [PR REVIEW] " paper42
2023-04-07 13:02 ` paper42
2023-04-07 13:02 ` paper42
2023-04-07 13:02 ` paper42
2023-04-07 13:02 ` paper42
2023-04-11  9:15 ` [PR PATCH] [Updated] " adigitoleo
2023-04-11  9:17 ` adigitoleo
2023-04-11 11:40 ` [PR PATCH] [Updated] " adigitoleo
2023-04-11 11:51 ` adigitoleo [this message]
2023-07-11  2:02 ` github-actions
2023-07-26  1:56 ` [PR PATCH] [Closed]: " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230411115119.XOONgYrXjaksDDgvAc_oSBOozqkfhxwcfAwgSSELjD0@z \
    --to=adigitoleo@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).