From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: common/build-style/python3-pep517.sh: unpack wheels for testing
Date: Wed, 12 Apr 2023 21:55:05 +0200 [thread overview]
Message-ID: <20230412195505.SxEmSyTCg5hCT5Izn2ah7962qkenOcHlp8LD1rtl4lw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42013@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
There's a closed pull request on the void-packages repository
common/build-style/python3-pep517.sh: unpack wheels for testing
https://github.com/void-linux/void-packages/pull/42013
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
Python packages built with pep517 system occasionally require accessing distinfo files and/or entry points provided by the package for tests to run. Since these assets are packed inside the wheel generated in `do_build`, the target wheel is unpacked in `do_check` first so that the said artifacts are accessible during test runs.
Initially I unpacked the wheel during `do_build` with the `do_install` only copying the unarchived files (similar to the zig build style). That required patching pep517 templates with explicit `do_build` but no explicit `do_install`. There were only four such cases and it worked fine for me locally but maybe that was too big of a change so submitting this version for now instead.
The later commits are for demonstration purpose and not intended for merging. Those templates (and hopefully all others) still work fine as is.
prev parent reply other threads:[~2023-04-12 19:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 14:52 [PR PATCH] " icp1994
2023-04-12 19:46 ` classabbyamp
2023-04-12 19:55 ` ahesford
2023-04-12 19:55 ` ahesford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412195505.SxEmSyTCg5hCT5Izn2ah7962qkenOcHlp8LD1rtl4lw@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).