Github messages for voidlinux
 help / color / mirror / Atom feed
From: Johnnynator <Johnnynator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: electron19: fix build
Date: Thu, 13 Apr 2023 03:18:03 +0200	[thread overview]
Message-ID: <20230413011803.I7FgzGTCpv8Eu8T1lgMS6ldgmPp07nlLkPwB0VXoJf0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43376@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 815 bytes --]

There's a merged pull request on the void-packages repository

electron19: fix build
https://github.com/void-linux/void-packages/pull/43376

Description:
[ci skip]

#### Testing the changes
- I tested the changes in this PR: **NO** (but yes? because it's for the build)

#### Local build testing
- I built this PR locally for my native architecture, **x86_64**


#### Comments

While checking ffmpeg5/6 changes I was having trouble building `electron19`. There have been a few big changes lately and the last build fix was months ago, so I'm not sure what changed. (Looks like a lot of active patching or something in the template?)

~~Going to verify non-ffmpeg change build tonight if I remember.~~

part https://github.com/void-linux/void-packages/issues/39083 (not on list)

question: revbump?

      reply	other threads:[~2023-04-13  1:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-10 16:54 [PR PATCH] " zlice
2023-04-13  1:18 ` Johnnynator [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230413011803.I7FgzGTCpv8Eu8T1lgMS6ldgmPp07nlLkPwB0VXoJf0@z \
    --to=johnnynator@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).