* Re: [PR REVIEW] evince: update to 44.1
2023-04-13 19:12 [PR PATCH] evince: update to 44.1 pascal-huber
@ 2023-04-13 20:55 ` mhmdanas
2023-04-13 21:16 ` mhmdanas
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: mhmdanas @ 2023-04-13 20:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
New review comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/43428#discussion_r1165993761
Comment:
```suggestion
changelog="https://gitlab.gnome.org/GNOME/evince/-/raw/gnome-${version%.*}/NEWS"
```
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: evince: update to 44.1
2023-04-13 19:12 [PR PATCH] evince: update to 44.1 pascal-huber
2023-04-13 20:55 ` [PR REVIEW] " mhmdanas
@ 2023-04-13 21:16 ` mhmdanas
2023-04-13 21:46 ` paper42
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: mhmdanas @ 2023-04-13 21:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/43428#issuecomment-1507620157
Comment:
By the way, you don't really have to do these cross-builds locally, since that's done in the CI in this case.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: evince: update to 44.1
2023-04-13 19:12 [PR PATCH] evince: update to 44.1 pascal-huber
2023-04-13 20:55 ` [PR REVIEW] " mhmdanas
2023-04-13 21:16 ` mhmdanas
@ 2023-04-13 21:46 ` paper42
2023-04-13 21:47 ` [PR REVIEW] " paper42
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2023-04-13 21:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/43428#issuecomment-1507647157
Comment:
We actually do want the systemd service files for documentation purposes, leave them there
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] evince: update to 44.1
2023-04-13 19:12 [PR PATCH] evince: update to 44.1 pascal-huber
` (2 preceding siblings ...)
2023-04-13 21:46 ` paper42
@ 2023-04-13 21:47 ` paper42
2023-04-13 22:11 ` [PR PATCH] [Updated] " pascal-huber
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2023-04-13 21:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/43428#discussion_r1166060182
Comment:
no, let's keep hardcoding the version in the template, it's much easier to just click on the link instead of having to use xbps-src show to get it
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] evince: update to 44.1
2023-04-13 19:12 [PR PATCH] evince: update to 44.1 pascal-huber
` (3 preceding siblings ...)
2023-04-13 21:47 ` [PR REVIEW] " paper42
@ 2023-04-13 22:11 ` pascal-huber
2023-04-13 22:12 ` [PR REVIEW] " pascal-huber
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: pascal-huber @ 2023-04-13 22:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
There is an updated pull request by pascal-huber against master on the void-packages repository
https://github.com/pascal-huber/void-packages evince
https://github.com/void-linux/void-packages/pull/43428
evince: update to 44.1
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64-musl (crossbuild)
- armv7l (crossbuild)
- aarch64 (crossbuild)
A patch file from https://github.com/void-linux/void-packages/pull/43428.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-evince-43428.patch --]
[-- Type: text/x-diff, Size: 1563 bytes --]
From 80336761ff8d2899e30a363bebc611779d7aee5d Mon Sep 17 00:00:00 2001
From: Pascal Huber <pascal.huber@resolved.ch>
Date: Thu, 13 Apr 2023 21:06:27 +0200
Subject: [PATCH] evince: update to 44.1
---
srcpkgs/evince/template | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/evince/template b/srcpkgs/evince/template
index 1a5101e90dff..a3b6471a6612 100644
--- a/srcpkgs/evince/template
+++ b/srcpkgs/evince/template
@@ -1,12 +1,11 @@
# Template file for 'evince'
pkgname=evince
-version=44.0
+version=44.1
revision=1
build_helper="gir"
build_style=meson
configure_args="$(vopt_bool gir introspection) $(vopt_bool gtk_doc gtk_doc)
- -Dcomics=enabled -Ddjvu=enabled -Dps=enabled -Dxps=enabled -Ddvi=disabled -Dpdf=enabled
- -Dnautilus=false"
+ -Dcomics=enabled -Ddjvu=enabled -Dps=enabled -Dxps=enabled -Ddvi=disabled -Dpdf=enabled"
hostmakedepends="adwaita-icon-theme gettext $(vopt_if gtk_doc gi-docgen)
glib-devel itstool pkg-config perl-XML-Parser appstream-glib desktop-file-utils"
# XXX missing packages for DVI backend.
@@ -21,7 +20,7 @@ homepage="https://wiki.gnome.org/Apps/Evince"
#changelog="https://gitlab.gnome.org/GNOME/evince/-/raw/main/NEWS"
changelog="https://gitlab.gnome.org/GNOME/evince/-/raw/gnome-44/NEWS"
distfiles="${GNOME_SITE}/evince/${version%.*}/evince-${version}.tar.xz"
-checksum=339ee9e005dd7823a13fe21c71c2ec6d2c4cb74548026e4741eee7b2703e09da
+checksum=15afd3bb15ffb38fecab34c23350950ad270ab03a85b94e333d9dd7ee6a74314
build_options="gir gtk_doc"
build_options_default="gir gtk_doc"
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] evince: update to 44.1
2023-04-13 19:12 [PR PATCH] evince: update to 44.1 pascal-huber
` (4 preceding siblings ...)
2023-04-13 22:11 ` [PR PATCH] [Updated] " pascal-huber
@ 2023-04-13 22:12 ` pascal-huber
2023-04-13 22:13 ` pascal-huber
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: pascal-huber @ 2023-04-13 22:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
New review comment by pascal-huber on void-packages repository
https://github.com/void-linux/void-packages/pull/43428#discussion_r1166077926
Comment:
ok, left it hardcoded.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: evince: update to 44.1
2023-04-13 19:12 [PR PATCH] evince: update to 44.1 pascal-huber
` (5 preceding siblings ...)
2023-04-13 22:12 ` [PR REVIEW] " pascal-huber
@ 2023-04-13 22:13 ` pascal-huber
2023-04-13 22:14 ` pascal-huber
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: pascal-huber @ 2023-04-13 22:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
New comment by pascal-huber on void-packages repository
https://github.com/void-linux/void-packages/pull/43428#issuecomment-1507675108
Comment:
> By the way, you don't really have to do these cross-builds locally, since that's done in the CI in this case.
I was wondering about that - though I usually run them anyways as my computer is faster than CI.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: evince: update to 44.1
2023-04-13 19:12 [PR PATCH] evince: update to 44.1 pascal-huber
` (6 preceding siblings ...)
2023-04-13 22:13 ` pascal-huber
@ 2023-04-13 22:14 ` pascal-huber
2023-04-13 22:17 ` pascal-huber
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: pascal-huber @ 2023-04-13 22:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 434 bytes --]
New comment by pascal-huber on void-packages repository
https://github.com/void-linux/void-packages/pull/43428#issuecomment-1507675956
Comment:
> Remove `-Dnautilus=false` from `configure_args` (it's now the default), and add `-Dsystemduserunitdir=no` (we don't want the systemd service files).
>
> Otherwise, this looks good to me, and I tested it without issues.
I left the `-Dsystemduserunitdir=no` as @paper42 suggested.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: evince: update to 44.1
2023-04-13 19:12 [PR PATCH] evince: update to 44.1 pascal-huber
` (7 preceding siblings ...)
2023-04-13 22:14 ` pascal-huber
@ 2023-04-13 22:17 ` pascal-huber
2023-04-13 22:54 ` mhmdanas
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: pascal-huber @ 2023-04-13 22:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
New comment by pascal-huber on void-packages repository
https://github.com/void-linux/void-packages/pull/43428#issuecomment-1507675956
Comment:
> Remove `-Dnautilus=false` from `configure_args` (it's now the default), and add `-Dsystemduserunitdir=no` (we don't want the systemd service files).
>
> Otherwise, this looks good to me, and I tested it without issues.
I didn't add `-Dsystemduserunitdir=no` as @paper42 suggested.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: evince: update to 44.1
2023-04-13 19:12 [PR PATCH] evince: update to 44.1 pascal-huber
` (8 preceding siblings ...)
2023-04-13 22:17 ` pascal-huber
@ 2023-04-13 22:54 ` mhmdanas
2023-04-23 0:00 ` [PR PATCH] [Updated] " pascal-huber
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: mhmdanas @ 2023-04-13 22:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 214 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/43428#issuecomment-1507702918
Comment:
@paper42 thanks for the heads-up, I thought it was simply an oversight.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] evince: update to 44.1
2023-04-13 19:12 [PR PATCH] evince: update to 44.1 pascal-huber
` (9 preceding siblings ...)
2023-04-13 22:54 ` mhmdanas
@ 2023-04-23 0:00 ` pascal-huber
2023-05-27 14:21 ` mhmdanas
2023-06-04 10:43 ` [PR PATCH] [Merged]: " paper42
12 siblings, 0 replies; 14+ messages in thread
From: pascal-huber @ 2023-04-23 0:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
There is an updated pull request by pascal-huber against master on the void-packages repository
https://github.com/pascal-huber/void-packages evince
https://github.com/void-linux/void-packages/pull/43428
evince: update to 44.1
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64-musl (crossbuild)
- armv7l (crossbuild)
- aarch64 (crossbuild)
A patch file from https://github.com/void-linux/void-packages/pull/43428.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-evince-43428.patch --]
[-- Type: text/x-diff, Size: 1577 bytes --]
From 9057e4fea9b8c6e867dc5eb290789cb4fe022275 Mon Sep 17 00:00:00 2001
From: Pascal Huber <pascal.huber@resolved.ch>
Date: Thu, 13 Apr 2023 21:06:27 +0200
Subject: [PATCH] evince: update to 44.1
---
srcpkgs/evince/template | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/evince/template b/srcpkgs/evince/template
index 81d808d5b9b9..a3b6471a6612 100644
--- a/srcpkgs/evince/template
+++ b/srcpkgs/evince/template
@@ -1,12 +1,11 @@
# Template file for 'evince'
pkgname=evince
-version=44.0
-revision=2
+version=44.1
+revision=1
build_helper="gir"
build_style=meson
configure_args="$(vopt_bool gir introspection) $(vopt_bool gtk_doc gtk_doc)
- -Dcomics=enabled -Ddjvu=enabled -Dps=enabled -Dxps=enabled -Ddvi=disabled -Dpdf=enabled
- -Dnautilus=false"
+ -Dcomics=enabled -Ddjvu=enabled -Dps=enabled -Dxps=enabled -Ddvi=disabled -Dpdf=enabled"
hostmakedepends="adwaita-icon-theme gettext $(vopt_if gtk_doc gi-docgen)
glib-devel itstool pkg-config perl-XML-Parser appstream-glib desktop-file-utils"
# XXX missing packages for DVI backend.
@@ -21,7 +20,7 @@ homepage="https://wiki.gnome.org/Apps/Evince"
#changelog="https://gitlab.gnome.org/GNOME/evince/-/raw/main/NEWS"
changelog="https://gitlab.gnome.org/GNOME/evince/-/raw/gnome-44/NEWS"
distfiles="${GNOME_SITE}/evince/${version%.*}/evince-${version}.tar.xz"
-checksum=339ee9e005dd7823a13fe21c71c2ec6d2c4cb74548026e4741eee7b2703e09da
+checksum=15afd3bb15ffb38fecab34c23350950ad270ab03a85b94e333d9dd7ee6a74314
build_options="gir gtk_doc"
build_options_default="gir gtk_doc"
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: evince: update to 44.1
2023-04-13 19:12 [PR PATCH] evince: update to 44.1 pascal-huber
` (10 preceding siblings ...)
2023-04-23 0:00 ` [PR PATCH] [Updated] " pascal-huber
@ 2023-05-27 14:21 ` mhmdanas
2023-06-04 10:43 ` [PR PATCH] [Merged]: " paper42
12 siblings, 0 replies; 14+ messages in thread
From: mhmdanas @ 2023-05-27 14:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/43428#issuecomment-1565450555
Comment:
Tested this and it's working fine, so it should be good to go IMO (unless you've got some changes to suggest @paper42?).
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Merged]: evince: update to 44.1
2023-04-13 19:12 [PR PATCH] evince: update to 44.1 pascal-huber
` (11 preceding siblings ...)
2023-05-27 14:21 ` mhmdanas
@ 2023-06-04 10:43 ` paper42
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2023-06-04 10:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
There's a merged pull request on the void-packages repository
evince: update to 44.1
https://github.com/void-linux/void-packages/pull/43428
Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64-musl (crossbuild)
- armv7l (crossbuild)
- aarch64 (crossbuild)
^ permalink raw reply [flat|nested] 14+ messages in thread